upstream pull#4
Draft
ivomink wants to merge 3956 commits into
Draft
Conversation
## Short description Cyclorites disarm chance has been raised to 50% with their damage now doing 50 stamina damage. Their punch time is still slow, causing them to only have this chance twice as slow as a regular human. _Genuinely been waiting for a while to do this, but have been pretty well absent._ ## Why we need to add this Cyclorites for some reason can punch way harder than a human, but shove not only twice as slow, but the same chance as a human. This makes shoving as a cyclorite basically impossible making any and all chances for shove fights favour those with faster shoves. Now for the reason why they do 50 stamina damage? Chance = Damage. I'm not kidding. There is no way to make cyclorites just do more damage or higher chance. It's both intertwined. I am not gonna weed through the C# that is upstream code to try and disconnect the two. ## Media (Video/Screenshots) <img width="646" height="55" alt="image" src="https://github.com/user-attachments/assets/84f3d362-3c10-4032-a23d-cfbdaa6503f5" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Coolsurf6 - tweak: Cyclorites now shove 50% of the time rather than 25% due to their slow shoves. - tweak: Cyclorite shoves now do 50 stamina. Co-authored-by: Coolsurf6 <coolsurf24@yahoo.com.au>
## Short description Adds the Vulpkanin Down Husky tail marking with wagging sprites, fixes its body layering so obscured portions render behind the body, and makes its customization use two color choices like other husky-style tails. ## Why we need to add this The Down Husky tail has been brought over at Aubryn's request, and made consistent with existing tail behavior. The split tail layering prevents the front-facing sprite from visibly drawing over body parts that should obscure it, and the two-color setup matches the customization flow used by similar husky tails. ## Media (Video/Screenshots) <details> <summary>Click to view images</summary> <img width="3840" height="2160" alt="image" src="https://github.com/user-attachments/assets/f0b0131a-75f8-4d65-b089-231e80b56b7a" /> <img width="157" height="220" alt="image" src="https://github.com/user-attachments/assets/1bad733f-c3a7-41c3-a28b-9c945d3f1738" /> </details> ## Checks - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: - add: Added the Vulpkanin Down Husky tail marking, including wagging sprites. - tweak: Down Husky tail coloring now uses two color options, matching other husky-style tails. - fix: Down Husky tail sprites now layer correctly behind the body where obscured.
## Short description <!-- What do you propose to change with your PR? --> Fixes some code issues, adds more prediction for vent crawl. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Better crawl? ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> Vent Crawling overlay: <img width="545" height="964" alt="image" src="https://github.com/user-attachments/assets/d30b590b-e69d-4152-8d8f-fcec7c350cd5" /> More structures available for crawling: <img width="361" height="554" alt="image" src="https://github.com/user-attachments/assets/54e76011-120e-407f-bf66-93bd34ffdb00" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Rinary - add: Added vision overlay for Vent Crawling, so now you see pipes and current pipe when crawling. - add: Added vent crawling support for almost all pipe devices, such as radiators, freezers, heaters, so now you won't exit from vents after entering in them. - add: Added layers support for vent crawling. - tweak: Predicted and improved more things from VentCrawl system, so now it will be smoother on clients. - tweak: Changed vent crawling exit, now instead of insta exiting from vents when reaching enter, you'll have action for exit. - tweak: Changed passive vents, now you can enter vents through passive vents and weld them. - tweak: Changed players ratio for princess spawn, now 1 princess per 50 players, I.e. 3 on 150 pop. - fix: Again fixed terror spiders rule by forcing 50 players minimum. - fix: Fixed double wrap actions on terror princess and purple terror spider. - fix: Fixed bug when you can't see anything while standing IN vents/scrubbers. - fix: Fixed bug when terror spiders can spin web in containers(including vents). - fix: Fixed bug when princess of terror can't reopen eggs laying menu after closing. - fix: Fixed bug when vent crawling movement controls don't rotate with camera.
## Short description Adjusted Tallborg sprites in several ways to help with some concerns raised: - All sprites have been shortened by roughly 3 pixels. - All sprites have been shifted up in the texture significantly. A tallborg pressed as close to a wall below them as possible now only has their feet clip, about 4 pixels into the wall. Compared to before where they clipped all the way to their hips, this is greatly improved. - Shading on all sprites was tweaked to make the outlines more consistent, reduce redundant hues in shading, to dim the highlights, and to lighten the shadows. Overall, stronger outlines and lower contrast makes them match more closely with our existing borg sprites. ## Why we need to add this Shading improvements and fixes the clipping about 95%. ## Media (Video/Screenshots) <img width="871" height="392" alt="image" src="https://github.com/user-attachments/assets/dc02c4ac-37e3-4252-9319-b54674cca0ad" /> <img width="879" height="396" alt="image" src="https://github.com/user-attachments/assets/4e8616ad-07af-4290-b050-093c891b211c" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Conflee - tweak: Edited the shading of the Tallborgs to be lower contrast, have a most consistent outline, and reduce redundant hues in shading. Overall their new look matches more closely with other Cyborg chassis options. - fix: Fixed Tallborg's legs clipping severely through walls below them. Pressed as close to the wall as possible, now only their feet clip, about 4 pixels vs the prior 12ish pixels.
Made no sense otherwise, they were the most cost effective barrier ## Short description Made Security Turnstiles take Structural damage ## Why we need to add this Security Turnstiles take 3 steel to construct, which gives you a 500 HP barrier that took no structural damage. Needing 47 breaching hammer hits and tons of ammo to bring down. Given how cheap it is to construct it can be very annoying to deal with when spammed. Also being a security turnstile, they were made significantly difficult to deconstruct, both in steps, tools and doafters. https://discord.com/channels/1272545509562777621/1302787783135596604 ## Checks - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [ ] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: - tweak: Turnstiles now take Structural Damage.
## Short description Makes the NanoTrasen lockers more uniform with each other + adds an NCT Locker. NCT's locker doesn't really need to be mapped unless people want to. ## Why we need to add this NT Rep and BSO's lockers were different colored, and since we recently got rid of the law department and grouped all NT Personnel together, I made the other 2 lockers match the existing ones + made an NCT locker. ## Media (Video/Screenshots) <img width="713" height="201" alt="image" src="https://github.com/user-attachments/assets/6a4a5580-4d2f-4719-a702-fcef62b59f8a" /> Other than the glasses, the NCT's locker doesn't contain anything of note. <img width="398" height="333" alt="image" src="https://github.com/user-attachments/assets/3e123c32-6c8d-4526-8304-ac2459f7b924" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulnewworld - add: Added a NanoTrasen Career Trainer locker. - tweak: The NanoTrasen Representative and Blueshield Officer's lockers now match the Magistrate/Internal Affairs Agents' lockers. - tweak: Tweaks some shading on the Magistrate's locker. (4 pixels).
## Short description Moves our version of the Magistrate's robes made in [#3032](#3032) to our files, and restores Wizden's version back where it was originally was. Differentiates between the two, with the Judge Robes being the one anyone can get from the autodrobe, while the Magistrate Robes are available only to the Magistrate. Also fixes some typos and pet peeves from my recent Cold outfit PR. ## Why we need to add this Original PR replaced Wizden files, and we should not do that. ## Media (Video/Screenshots) They are different items. <img width="278" height="155" alt="image" src="https://github.com/user-attachments/assets/e595edba-f0a6-49a7-aa90-48654a465473" /> <img width="515" height="156" alt="image" src="https://github.com/user-attachments/assets/8715865e-ac98-4063-8d1f-3f6dcb0f1d00" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulneworld - add: Restores Wizden's original judge robes. - tweak: Magistrate Jacket and NT Rep Jacket now properly have cold resist, and now actually share the exact same stats with each other. - tweak: Moves our current judge robes to magistrate robes, available to the Magistrate only. They have the same stats as the prior two items, and are NanoTrasen contraband. - fix: Fixes some grammar with BSO's overcoat. - fix: Fixes some capitalization inconsistency.
## Short description we can now beat people to death with weapons used for shooting ## Why we need to add this it's very cool and immersive ## Media (Video/Screenshots) https://github.com/user-attachments/assets/ebbac04b-acfa-454a-8ff5-80162bd575d7 ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: StrangerOfParadiseOG - add: Added pistol whipping to MOST firearms.
## Short description <!-- What do you propose to change with your PR? --> Corrects Secure Trespass as per the request of @Conflee Also removes vestigial mention of EoC in crimelist that I didn't perform properly back when I did it. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="542" height="119" alt="billede" src="https://github.com/user-attachments/assets/76babfc1-8213-4e48-8886-8f8c5fca1c75" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description <!-- What do you propose to change with your PR? --> Pulls some changes from our engine ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description <!-- What do you propose to change with your PR? --> I have added back the Resomi Scream sound effect which was removed in PR #2364. The original sound was missing attribution, and after a drunken late night search by yours truly. I was able to locate the original sound effect and attribute it to ZapSplat. ZapSplat licenses its sound effects under a custom "Standard License" which prohibits re-distribution entirely, making any sound from ZapSplat incompatible with any SS14 fork. Since hosting the file on GitHub would be considered distribution. I managed to reach out to the owner of the sound effect, Alan McKinney, who is also the founder of ZapSplat. In private communications, he offered to dual license the sound under Creative Commons 4.0 without compensation despite me offering to compensate him. However, he did state that this is a once of gift and not to expect him or his company to dual license any of their sounds in the future. With the sound dual licensed under CC-BY-4.0, it can be returned to the game. See below .pdf for license information. [Alan_McKinney_CC_BY_4.0_License_Grant .pdf](https://github.com/user-attachments/files/28740618/Alan_McKinney_CC_BY_4.0_License_Grant.pdf) Important to note, "am_budgie_single_chirp.wav" was reformated to .ogg and renamed to "resomi_scream.ogg". ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> The original scream sound effect was an absolute banger. Currently they have the Avali scream sound effect, and giving Resomi back their unique scream sound is peak. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. --> :cl: Huaqas - tweak: Resomi's original scream sound effect has returned. Chirpers rejoice.
## Short description It's a lot of fixes. Like, a ton. Ports the marking fixes in Far Horizon [#819](Far-Horizons-SS14/Far-Horizons-SS14#819). ## Why we need to add this Bug fixes are bug fixes ## Media (Video/Screenshots) <img width="1183" height="325" alt="image" src="https://github.com/user-attachments/assets/a9fc98c5-068d-4932-89ca-b5704ee99634" /> <img width="582" height="352" alt="image" src="https://github.com/user-attachments/assets/7a99af74-1fdc-49d3-8ffd-16cafde3e438" /> <img width="1618" height="589" alt="image" src="https://github.com/user-attachments/assets/95049e5f-4f48-459f-8938-49a07e8c2095" /> <img width="256" height="840" alt="image" src="https://github.com/user-attachments/assets/50872d57-c99d-4c72-b8da-0ac49df3222c" /> ## Checks - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: wonderfulnewworld, Princess Gurchi - add: You can now select your Protogen frame for Nukeops, NukeopsCommander, NukeopsMedic, SpaceNinja, Wizard, and WizardDuelist. - add: Protogen Markings are now split up into their own categories, and now actually work on all species thanks to being split across new body layers. - tweak: Protogen Frame selection is a bit more clear in the menu now. - tweak: Basic-Class Medium Protogen Armor now has 5% Pierce Resist. - tweak: Proto-Moth Cold Resist +5%, Heat Vulnerability +5%. - tweak: Proto-Diona Slash Resist +15%, Heat Vulnerability +15%, Shock Vulnerability +20%. - tweak: Computer Boards are less nutritious, eat real food sometimes! - tweak: Updated ProtoKin's guidebook entry to specify they don't passively heal burn anymore. (This is due to their 50% healing reduction). - fix: Dwarves and Skeletons can open airlocks and pilot stuff again. - fix: Medical Huds (all types) can now correctly see Protogen health. - fix: Proto-Lagomorph metabolism now matches normal Lagomorph metabolism. - fix: Proto-Reptilians no longer freeze to death after leaving cryo healing pods. - fix: Protogen tails now correctly make the thump sound. - fix: Proto-Resomi use the base Resomi Gasp, Deathgasp, Sigh, Cough, and Yawn. - fix: All Protogen can now get hand implants. - fix: True Protogen can be picked up. - fix: ProtoKin can hear Empathy now. - fix: Proto-Vulps no longer starve 10x faster than they're supposed to. - fix: The Duty Officer's Winter Coat now has a suit storage slot.
## Short description <!-- What do you propose to change with your PR? --> Fixing a critical issue with security's wiring that prevents half of security being fed power correctly at every shift start. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Critical issue. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="316" height="321" alt="image" src="https://github.com/user-attachments/assets/89a16044-bf99-4b61-addc-de16a6ae57ce" /> <img width="534" height="598" alt="image" src="https://github.com/user-attachments/assets/bee88518-077d-43ea-bd4b-2d2d32f475e5" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Cvlancer - fix: Fixed the east side security substation not receiving power by removing a cable terminal.
## Short description <!-- What do you propose to change with your PR? --> Fixes erroneous behavior with force prototypes. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Force prototype brokey ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions.
## Short description <!-- What do you propose to change with your PR? --> Removes the large warden locker's prototype and art assets. A `migration.yml` entry has been created to replace any large variants of the lockers with normal ones. This isn't needed for mapping (the locker is not used in any maps) _but_ I didn't want to risk bricking any of the Event Coordinator's custom grids. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> It's not used in game. There was a brief period where two Wardens was being tested, but we went with implementing Duty Officers instead. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="487" height="472" alt="image" src="https://github.com/user-attachments/assets/708fb627-257a-4f7c-929c-17f15da1f40d" /> fig. 1 - 'tis gone. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - remove: The large version of the warden locker has been removed due to being unused.
## Short description <!-- What do you propose to change with your PR? --> Basically every gun in the game can fit in your suit storage. Generally, for pistols: - They fit in your belt slot. - They fit in your suit storage slot. Generally, for rifles: - They fit in your back slot. - They fit in your suit storage slot. The hybrid taser didn't fit in your suit storage, even though the dominator and disabler pistols do. This PR fixes that. The ion rifle didn't fit on in your suit storage slow, even though all other rifles in the game do. This PR also fixes that. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Bugfix as far as I can tell + consistency fix. This has driven me insane playing security recently because I usually put my disabler weapons in my suit storage. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="812" height="474" alt="Hybrid Taser" src="https://github.com/user-attachments/assets/cb06360a-c846-463b-8b86-cd0098fa3606" /> fig. 1 - Before and After PR. I'm using the hotkey to put things into suit storage here. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - fix: Security's Hybrid Taser now fits in your suit storage, just like the Disabler and Dominator. - fix: The Ion Rifle now fits in your suit storage, just like other rifles.
## Short description <!-- What do you propose to change with your PR? --> manual port of space-wizards/space-station-14#43208 Empty water bottles are correctly suffixed in dev also why is pulped banana peel the only one with dashes that isn't a shorthand? ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> fix is good ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> <img width="816" height="394" alt="image" src="https://github.com/user-attachments/assets/d3ec95c4-5e5c-4820-a13d-dc6951a6c758" /> ## Checks <!-- check boxes for faster reviewing of your PR --> - [X] I do not require assistance to complete the PR. - [X] Before posting/requesting review of a PR, I have verified that the changes work. - [X] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [X] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: - fix: Some reagent bottles now have the correct labels.
…ce, new power source. (#4687) ## Short description Fully reworking the atmospherics to use the pipe layering system. Made the power source an actual power source instead of a shitty debug gen. Did some small reworks of places such as the CC pavilion and the entrance to security. ## Why we need to add this This maps unmaintained, and im tryna bring it up a bit more. Also the pipes look cooler when using pipe layering, and having an actual power source feels alot less cheaty then just a debug gen, and its also cooler. ## Media (Video/Screenshots) <img width="561" height="589" alt="image" src="https://github.com/user-attachments/assets/44a2d40f-1fe0-4c9c-9747-fa540dc8ae2d" /> ## Checks - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - remove: (CC_SC17) Completely removed the old atmospherics piping and such. - add: (CC_SC17) Completely new atmospherics piping and layout. - tweak: (CC_SC17) Security front entrance now stops those tiders from breakin in.
## Short description <!-- What do you propose to change with your PR? --> The siren for Code Violet has two problems - It's super loud - It abruptly cuts off at the end (it doesn't fade out) This PR drops the volume by -3dB, reduces it from 30 seconds to 25 seconds, and makes the ending fade out smoothly. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> The current siren is obnoxiously loud and long. The cut-off at the end makes it feel low quality. This PR fixes the abrupt cutoff and makes the siren a little less loud and a little less obnoxious. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> https://github.com/user-attachments/assets/267ad40b-f3ee-46df-8b02-b76e5e322075 fig. 1 - Video of the changes to the siren sound. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - tweak: The siren for Code Violet is now a little quieter. - fix: The siren for Code Violet now fades out instead of just cutting off at the end.
## Short description <!-- What do you propose to change with your PR? --> The mime's vow of silence is really easily circumvented. The whole point of miming is **pantomiming.** This PR makes the vow of silence much stronger, preventing the mime from using the following while their vow is unbroken: - No writing while the vow is active. - No using AAC tablets while the vow is active. - No using sign language or hiveminds (like the Nexus) while the vow is active - No using NanoChat while the vow is active. - No printing non-blank NanoTasks. I figured it's funny if the mime can still print NanoTasks whilst maintaining their vow as long as the NanoTask itself is completely blank. One issue with this PR that I couldn't figure out was how to make the NanoChat messages fail more gracefully (the Mime is prevented from sending NanoChats properly, but the messages appear briefly before flickering out). I would appreciate if someone smarter than me can figure out how to prevent that message flickering. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> Writing, AAC tablets, sign language, hiveminds, NanoChat and NanoTasks all circumvent the point of the vow of silence. Discord support for mimes actually being silent is extremely strong, as seen in this thread: https://discord.com/channels/1272545509562777621/1513943733492777192 <img width="618" height="94" alt="image" src="https://github.com/user-attachments/assets/6c68c6c6-25f3-40e1-b02b-d04e7d59ba3c" /> ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> https://github.com/user-attachments/assets/28d8dd56-f9a9-460f-8646-e480cdd2b9d1 fig. 1 - Demo: AAC tablet prevention, NanoChat prevention, non-verbal language prevention, NanoTask writing prevention, blank NanoTasks are still allowed, writing prevention. Mime vow is then broken and I show that all of these things still work after the mime vow is broken. ## Checks <!-- check boxes for faster reviewing of your PR --> - [ ] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - tweak: Mimes can no longer use AAC tablets while their vow of silence is active. - tweak: Mimes can no longer bypass their vow of silence by writing. - tweak: Mimes can no longer bypass their vow of silence using sign language nor hiveminds (e.g. the Nexus). - tweak: Mimes can no longer bypass their vow of silence by using NanoChat. - tweak: Mimes can no longer bypass their vow of silence by using NanoTasks (they may only print NanoTasks if the description is blank).
## Short description <!-- What do you propose to change with your PR? --> Replaces the 'experimental RCD' (recharging RCD) of cyborgs with a normal RCD and gives engineering cyborgs a whitelisted hand slot to carry RCD Ammo. Also included in this PR are some bugfixes: - `BorgModuleConstructionMaterialPlaceholder` wasn't hidden from the spawn menu when it really should be. It's the placeholder used for borg construction materials - it's not a useful spawn menu entry. - Depleting RCD ammo whether as a player or a cyborg would throw a giant stack trace. I've included this fix with a Starlight comment for now. I've opened a PR on upstream to fix it as well, since it affects all forks with prediction, I think: space-wizards/space-station-14#44274 Some closing remarks: - This PR has not touched the experimental RPD. I'm trying to keep the scope of the PR to one thing. - This PR doesn't touch Xenoborgs. This PR is just about the regular engineering cyborg module available to crew cyborgs. ## Why we need to add this <!-- What is the reason for adding these changes? Please post links to Discussions as well as Bug Reports here. Please describe how this will change the game balance. --> For the bugfixes: - They're bugfixes. If this PR is not accepted, I'll PR those separately. For the nerf: - Engineering cyborgs have had a lot of improvements over the year, especially with having whitelisted handslots to carry materials, wires, etc. They are at the point that many players feel they're just a better Engineer. - All access, meaning they can get to places much quicker than Engineers who need to wait for people (or the AI) to give access - Space immune, chemical and gas immune - Recharging RCD for free repairs - Recharging holofan, which Station Engineers sadly don't get - Not slowed down a by a big chunky hardsuit I'm not a cyborg hater, but let's be honest: Engineering cyborgs are really good. Requiring them to use RCD Ammo is mostly a nerf, though it does have the added buff that you don't have to sit and spin waiting for RCD charges to come back - you can just refill and build much quicker. ## Media (Video/Screenshots) <!-- If your PR contains in-game changes you must provide screenshots/videos of the changes. --> https://github.com/user-attachments/assets/d2b4790b-70f7-4d61-bf3b-1394380383d7 fig. 1 - RCD changes. ## Checks <!-- check boxes for faster reviewing of your PR --> - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** <!-- If you want the players to know about changes made in this PR, specify them using the template outside the comment. Short and informative. :cl: STARLIGHT TEAM - add: Added Starlight. - remove: Removed SS13. - tweak: Changed SS14. - fix: Fixed Rinary. --> :cl: Caws - add: Engineering cyborgs now have a 'hand' slot that can pick up RCD ammo, used for refilling RCDs. - remove: Removed the experimental RCD (recharging RCD) from engineering cyborgs due to budget cuts. Central Command apologies for the inconvenience.
## Short description Added Avali heart and lungs to the Medical Dispenser ## Why we need to add this https://discord.com/channels/1272545509562777621/1512299856666824856/1512299856666824856 When Avali or Resomi would be kidnapped by an abductor, they would have their heart replaced, if they wished to get the abductor organ removed the only hearts available were from humans, the bird lungs need amox while the bird heart needs dexp, leading to either poisoning them. ## Media (Video/Screenshots) <img width="462" height="463" alt="image" src="https://github.com/user-attachments/assets/466450a3-e0f3-47df-9dcf-f7854f14aacd" /> ## Checks - [x] I do not require assistance to complete the PR. - [x] Before posting/requesting review of a PR, I have verified that the changes work. - [x] I have added screenshots/videos of the changes, or this PR does not change in-game mechanics. - [x] I affirm that my changes are licensed under the [MIT License](https://github.com/ss14Starlight/space-station-14/blob/Starlight/LICENSE.TXT) and grant permission for use in this repository under its conditions. **Changelog** :cl: Musiklie - add: added Avali hearts and lungs to the Med dispenser. Co-authored-by: Rinary <rinary.super@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
LICENSE: BSD-2-Clause
Why we need to add this
Media (Video/Screenshots)
Checks
Changelog
🆑