feat: add support for yamllint.parse_custom_tags (enable for Pimcore)#69
Merged
youwe-petervanderwal merged 1 commit intomasterfrom Mar 13, 2026
Merged
Conversation
| - /^pdepend.xml$/ | ||
|
|
||
| yamllint.parse_constant: true | ||
| yamllint.parse_custom_tags: false |
Contributor
There was a problem hiding this comment.
Discussed to set the default to false (equal to GrumPHP default) and only make the change to default true for Pimcore projects/bundles.
Unless Magento devs say they want to have this changed too (in that case we can set it to true here immediately)
youwe-petervanderwal
approved these changes
Mar 5, 2026
youwe-petervanderwal
requested review from
Anve94,
DuckThom,
elzekool,
igorwulff,
kjkooistra-youwe,
leonhelmus and
rutgerrademaker
kjkooistra-youwe
approved these changes
Mar 6, 2026
youwe-petervanderwal
force-pushed
the
feat/yamllint-parse-custom-tags
branch
from
1696241 to
b616019
Compare
Contributor
|
Merging with bypassing failing build check - xmllint is failing due to #70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.