feat(api): return relative paths with system ID in media.search and media.lookup#565
Merged
wizzomafizzo merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
…edia.lookup Convert absolute file paths in media.search and media.lookup API responses to relative paths with the system ID as the first component. This makes paths portable across different mount points (e.g., removable drives) while remaining human-readable and usable as launch paths. Example: /mnt/games/SNES/USA/game.sfc → SNES/USA/game.sfc The conversion uses cached launcher data and platform root directories for pure string manipulation with no filesystem I/O at query time. URIs and unmatched paths are returned unchanged.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…older
filepath.IsAbs("/custom/ps2") returns false on Windows since it lacks a
drive letter. Use t.TempDir() to get a guaranteed-absolute path on all
platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToRelativePathmethod toLauncherCachethat converts absolute media file paths to relative paths with the system ID as the first component (e.g.,/mnt/games/SNES/USA/game.sfc→SNES/USA/game.sfc)HandleMediaSearchandHandleMediaLookupAPI handlers so returned paths are portable across different mount points