fix: #98 | Enhance the Try conditional recover and onFailure methods to use the predicate based methods

[ShivamNagpal]

closes #98

Summary by CodeRabbit

Release Notes

• New Features
  • Added recover methods supporting predicate-based exception matching for flexible conditional recovery.
  • Added onFailure callback methods supporting predicate-based exception matching for selective error processing.
  • New method overloads available as preview features providing enhanced control over failure handling and recovery scenarios.

[coderabbitai]

Walkthrough

Refactored Try exception recovery logic to support predicate-based filtering. Added new recover and onFailure methods accepting Predicate conditions, with existing exception-type variants delegating to predicate-based implementations. Updated compose behavior to route through failureMapper when Try is in failure state. Added @Preview annotations to varargs overloads and imported Predicate and Preview support.

Changes

Cohort / File(s)	Summary
Predicate-Based Recovery Refactoring src/main/java/org/zeplinko/commons/lang/ext/core/Try.java	Added foundational recover(Predicate, Function) and onFailure(Predicate, Consumer) methods; refactored recover(Class, Function) and onFailure(Class, Consumer) to delegate to predicate variants; marked recover(Function, Class...) and onFailure(Function/Consumer, Class...) varargs overloads with @Preview; updated compose to apply failureMapper when Try is failure; added Predicate and Preview imports.
Recovery Behavior Tests src/test/java/org/zeplinko/commons/lang/ext/core/TryTest.java	Added comprehensive test coverage for predicate-based recover and onFailure, including null-safety checks, predicate matching/non-matching scenarios, and varargs form behavior; adjusted existing assertions for delegation patterns.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Try
    participant Predicate
    participant Mapper
    
    User->>Try: recover(predicate, mapper)
    alt Exception exists
        Try->>Predicate: test(exception)
        alt Predicate matches
            Predicate-->>Try: true
            Try->>Mapper: apply(exception)
            Mapper-->>Try: Try<T> (recovered)
            Try-->>User: Success path
        else Predicate does not match
            Predicate-->>Try: false
            Try-->>User: Failure path (unchanged)
        end
    else No exception
        Try-->>User: Success path (direct)
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Key focus areas:
  • compose method behavioral change: now routes through failureMapper on failure instead of success path—verify this aligns with intended semantics
  • Predicate-based delegation chains in recover and onFailure overloads—trace execution paths to ensure correct branching
  • Null parameter handling in predicate and mapper arguments across new and refactored methods
  • @Preview annotation placement on varargs variants and implications for API stability
  • Parameter rename from failureMapper to mapper in recover(Class, Function) overload—check for consistency

Possibly related PRs

• feature: #98 | Ability to recover from specific exceptions #100: Modifies Try.java recovery and onFailure APIs with type-filtered exception handlers, addressing similar exception-specific recovery requirements.

Poem

🐰 With predicates as guides so fine,
We test each exception in line,
No casting chaos, no messy fray—
Try recovers the clever way!
✨ Exception handling—refined at last!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 39.29% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly references issue #98 and describes the main change: enhancing Try's conditional recovery and onFailure methods to use predicate-based approaches.
Linked Issues check	✅ Passed	The PR implements predicate-based recovery methods alongside type-specific overloads and varargs forms, directly addressing issue #98's requirement to eliminate verbose instanceof checks in exception recovery.
Out of Scope Changes check	✅ Passed	All changes are focused on enhancing Try's recovery and onFailure methods as specified in issue #98; no unrelated modifications were introduced.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 98-try-enhancements

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ShivamNagpal]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6f90f4 and d586ca4.

📒 Files selected for processing (2)

• src/main/java/org/zeplinko/commons/lang/ext/core/Try.java (10 hunks)
• src/test/java/org/zeplinko/commons/lang/ext/core/TryTest.java (4 hunks)

[a-anand-91119]

LGTM. One one concern, which is the same raised by code rabbit

[ShivamNagpal]

@a-anand-91119 It will be fixed in the next version.