Skip to content

chore(deps): update dependency jest-junit to v17 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smartway-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency jest-junit to v17 #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 21 additions & 17 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"eslint-plugin-react": "^7.34.1",
"eslint-plugin-react-hooks": "^4.6.0",
"jest": "^29.7.0",
"jest-junit": "^15.0.0",
"jest-junit": "^17.0.0",
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "1) Find where jest-junit is referenced/configured:"
rg -n --hidden --glob '!**/node_modules/**' 'jest-junit' .

echo "2) Find Jest reporter wiring (reporters array / junit output settings):"
rg -n --hidden --glob '!**/node_modules/**' --glob '!**/dist/**' --glob '!**/build/**' 'reporters|outputDirectory|outputName' .

echo "3) Locate likely Jest config files:"
find . -maxdepth 6 -type f \( -iname 'jest.config.*' -o -iname '*jest*.config.*' -o -iname '*.jest.*' \) 2>/dev/null || true

echo "4) After installing deps, run tests and confirm JUnit XML is produced:"
# Example (adjust to your package manager / CI expectations):
# yarn test
# ls -la junit* */junit* 2>/dev/null || true

Repository: ZeroGachis/smartway-react-native-ui

Length of output: 2028

🏁 Script executed:

cat -n ./jest.config.ts

Repository: ZeroGachis/smartway-react-native-ui

Length of output: 1071

🏁 Script executed:

cat -n ./.github/workflows/unit-tests.yml | head -60

Repository: ZeroGachis/smartway-react-native-ui

Length of output: 1696

🏁 Script executed:

web_search
jest-junit v17.0.0 breaking changes changelog

Repository: ZeroGachis/smartway-react-native-ui

Length of output: 179

🌐 Web query:

jest-junit version 17 release notes breaking changes

💡 Result:

jest-junit version 17.0.0 was tagged on 2026-04-24. The release page lists "Upgrade uuid package to latest - #284" but lacks detailed notes. The diff from v16.0.0 to v17.0.0 shows primarily maintenance updates: CI modernization, dependency upgrades (uuid to ^14.0.0, dev deps to Jest 30.2.0 and libxml2-wasm), switch from yarn to npm, removal of integration test dirs and Windows support, and snapshot/test updates. Breaking changes: - Node.js requirement raised from >=10.12.0 to >=20.0.0 (package.json engines field). - Removed integration-tests directories and related jest.config.js entries. - Switched XML validation library from libxmljs2 to libxml2-wasm in tests (may indirectly affect users if relying on specific behaviors). - Removed Windows-specific CI testing. No other explicit breaking API changes to reporter configuration or output format are documented. Existing configurations should work, but projects on Node <20 must upgrade Node.js.

Citations:

🏁 Script executed:

find ./.github/workflows -type f -name '*.yml' -o -name '*.yaml' | xargs grep -l 'unit-tests'

Repository: ZeroGachis/smartway-react-native-ui

Length of output: 115

🏁 Script executed:

cat -n ./.github/workflows/*.yml | grep -A 5 -B 5 'unit-tests' || true

Repository: ZeroGachis/smartway-react-native-ui

Length of output: 338

🏁 Script executed:

rg -n 'unit-tests.yml' ./.github/workflows/

Repository: ZeroGachis/smartway-react-native-ui

Length of output: 166

Upgrade Node.js to >=20.0.0 in CI, or downgrade jest-junit to v15/v16.

The jest-junit v17.0.0 upgrade requires Node.js >=20.0.0, but the CI workflow (pullrequest.yml) currently runs Node 18. This will cause installation or runtime failures. Either upgrade the Node.js version in pullrequest.yml from 18 to 20+ or downgrade jest-junit back to v15/v16 compatible with Node 18.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 63, CI currently runs Node 18 but package.json uses
"jest-junit": "^17.0.0" which requires Node >=20; either update the CI Node
version in pullrequest.yml to 20+ (change the setup-node action or uses: node:
'20') or pin the dependency in package.json to a Node-18-compatible version by
downgrading "jest-junit" to a v15 or v16 range; update the chosen file
(pullrequest.yml for Node upgrade or package.json for dependency downgrade) and
run install/test in CI to verify the fix.

"prettier": "3.2.5",
"prettier-eslint": "^16.3.0",
"ts-jest": "^29.1.0",
Expand Down
Loading