Add support for Digital Credentials on iOS#416
Conversation
gp-iaik
force-pushed
the
feature/ios_digital_credentials
branch
from
2aaaf57 to
c146b7f
Compare
gp-iaik
force-pushed
the
feature/ios_digital_credentials
branch
3 times, most recently
from
9417aae to
1f27b75
Compare
|
Requires update of multipaz to latest release |
gp-iaik
force-pushed
the
feature/ios_digital_credentials
branch
from
bcf68cd to
74b5d3c
Compare
|
TODO: fix proximity |
|
@gp-iaik |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
valera/shared/src/commonMain/kotlin/ui/navigation/WalletNavigation.kt
Lines 890 to 892 in 4621663
Use provisioning success route returned by the view model
ProvisioningIntentViewModel now returns AddCredentialDcApiSuccessRoute when a DC API issuance request is pending, but this callback ignores the returned route and always executes navigateBack(). For issuance flows completed after OAuth redirect, the success route is never shown, so the code path that returns a successful issuance response to the calling app is skipped.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
@n0900 is working on it |
…us/compose-wallet-app into feature/ios_digital_credentials
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
…gital_credentials
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
1 similar comment
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
gp-iaik
force-pushed
the
feature/ios_digital_credentials
branch
from
1d30bcf to
8ec30d7
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
1 similar comment
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
gp-iaik
force-pushed
the
feature/ios_digital_credentials
branch
from
e28777d to
a993ff3
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
gp-iaik
force-pushed
the
feature/ios_digital_credentials
branch
from
a993ff3 to
41c94d1
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
gp-iaik
force-pushed
the
feature/ios_digital_credentials
branch
from
41c94d1 to
620b43d
Compare
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
| kotlin { | ||
| val isMacHost = System.getProperty("os.name").lowercase().contains("mac") | ||
| val developerDir = if (isMacHost) { | ||
| project.providers.environmentVariable("DEVELOPER_DIR") |
There was a problem hiding this comment.
What value would I need to set here?
There was a problem hiding this comment.
This can be set to the Xcode directory, as shown in the examples at https://manpagez.com/man/1/xcode-select/
|
@codex review |
|
Still not building because linking of the Multipaz interop bridge fails :( |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 620b43daf1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onAcknowledge = { | ||
| walletMain.platformAdapter.prepareDCAPICredentialResponse(response, false) |
There was a problem hiding this comment.
prepareDCAPICredentialResponse(..., false) is now deferred into onAcknowledge, but that callback only runs when the user presses the error dialog button (ErrorViewModel wires it into onClickButton only). If a DCAPI error screen is dismissed via system back/gesture or another non-button exit path, no response is returned to the invoker, leaving the external request pending until timeout. This is especially visible in invocation flows where the caller expects an explicit failure callback.
Useful? React with 👍 / 👎.
| steps: | ||
| - name: Common setup | ||
| uses: a-sit-plus/internal-workflows/.github/actions/common-setup@v2 | ||
| uses: a-sit-plus/internal-workflows/.github/actions/common-setup@feature/bumpXcode |
There was a problem hiding this comment.
Switching reusable actions from a version tag to @feature/bumpXcode makes CI behavior non-deterministic because that branch can be force-pushed or deleted. A change outside this repo can silently alter or break release/test pipelines; using a tag or commit SHA keeps workflow execution reproducible and prevents unexpected pipeline regressions.
Useful? React with 👍 / 👎.
2 participants
Closes #163
Requires a-sit-plus/vck#538
Closes #432