Handle empty presentation matches without crashing#437
Handle empty presentation matches without crashing#437nodh wants to merge 1 commit intodevelopmentfrom
Conversation
|
iOS Build is fixed in #434 |
|
Closed in favor of #438 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f32f9d33a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (it is PresentationExchangeMatchingResult) { | ||
| validatePresentationExchangeInputDescriptorMatches(it.matchingResult.inputDescriptorMatches) |
There was a problem hiding this comment.
Route empty PE matches through the no-credential state
When an OpenID4VP/DCAPI Presentation Exchange request has at least one descriptor with no local match, this check now throws during toCredentialSelectionProvider(). In the graph-based flows (DefaultPresentationGraphViewModel/DCAPIPresentationGraphViewModel), that exception is converted to UiStateError, and PresentationGraphView immediately forwards it to onError, which WalletNavigation handles by popping back to HomeScreenRoute. The result is that a normal “no matching credential” case is now surfaced as a fatal error instead of the existing no-match UX used in AuthenticationViewModel.onConsent, so users lose the explanatory screen and are bounced out of the flow.
Useful? React with 👍 / 👎.
Summary
Verification
Fixes #436