Skip to content

Improve BGP load optimization HLD with ZMQ#2

Open
liuh-80 wants to merge 6 commits into
a114j0y:masterfrom
liuh-80:dev/liuh/zmq_bgp_enhance
Open

Improve BGP load optimization HLD with ZMQ#2
liuh-80 wants to merge 6 commits into
a114j0y:masterfrom
liuh-80:dev/liuh/zmq_bgp_enhance

Conversation

@liuh-80
Copy link
Copy Markdown

@liuh-80 liuh-80 commented Mar 4, 2024

According to discussion about improve BGP load optimization HLD with ZMQ, this PR will replace Orchagent improvement with ZMQ solution.

However, following part in HLD need update, because the reference content been remove and replaced with ZMQ:

### 2. Add an assistant thread to the monolithic Syncd main event loop workflow

For Syncd, we need to decouple _consumer.pop(kco, isInitViewMode())_ from _processSingleEvent(kco)_.

### Syncd [similar optimization to orchagent]

Similar case for syncd with orchagent. In our proposal, consumer.pop and processSingleEvent(kco) is decoupled.

@a114j0y a114j0y force-pushed the master branch 7 times, most recently from 0247ad7 to 892a1c3 Compare March 12, 2024 22:18
@liuh-80 liuh-80 reopened this Mar 15, 2024
</figure>

### 2. Add an assistant thread to the monolithic Orchagent/Syncd main event loop workflow

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part need re-write with Syncd code example, because orchagent already improve with ZMQ.

@liuh-80
Copy link
Copy Markdown
Author

liuh-80 commented Mar 15, 2024

@a114j0y please check and give your comments regarding to this HLD change proposal.

@a114j0y a114j0y force-pushed the master branch 2 times, most recently from e7fcc7b to 16cb696 Compare June 6, 2024 21:59
@a114j0y a114j0y force-pushed the master branch 8 times, most recently from 84c864b to 3eb70ac Compare July 20, 2024 03:13
@a114j0y a114j0y force-pushed the master branch 2 times, most recently from f4a58af to a8fa119 Compare July 23, 2024 14:45
a114j0y pushed a commit that referenced this pull request Jun 9, 2025
* Draft HLD document for portchannel interface

* Address Review Comments: Add Subscription desc. and change wording
a114j0y pushed a commit that referenced this pull request Jun 9, 2025
…review

HLD document for portchannel interface (#2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants