Skip to content

Conversation

@ehsavoie
Copy link
Collaborator

Introduce ServiceLoader-based A2AHttpClient client architecture with two implementations:

  • JDK HttpClient (core, always available)
  • Vert.x WebClient (optional, high-performance)

Changes:

  • Create http-client-vertx module for Vert.x implementation
  • Add ServiceLoader infrastructure (A2AHttpClientFactory, providers)
  • Update dependent modules to use Vert.x client by default
  • Add comprehensive tests and usage examples

Users can choose implementation via Maven dependencies. Priority-based selection: Vert.x (100) > JDK (0).

Fixes #583 🦕

@ehsavoie ehsavoie requested review from jmesnil and kabir January 13, 2026 14:16
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the HTTP client capabilities by introducing a pluggable architecture. It allows the system to dynamically select the most performant HTTP client available, with a new Vert.x-based client offering high-performance asynchronous operations, while retaining the JDK client as a reliable default. This change provides greater flexibility and potential for performance improvements without requiring explicit configuration from the end-user.

Highlights

  • Pluggable HTTP Client Architecture: Introduced a new ServiceLoader-based architecture for A2AHttpClient, allowing for flexible and extensible HTTP client implementations.
  • Vert.x WebClient Implementation: Added a high-performance Vert.x WebClient-based implementation, VertxA2AHttpClient, which is now the preferred default when Vert.x dependencies are available.
  • JDK HttpClient as Fallback: The existing JdkA2AHttpClient has been integrated into the new architecture as a fallback, ensuring a functional client is always available.
  • Automatic Client Selection: Implemented a priority-based selection mechanism where VertxA2AHttpClient (priority 100) is chosen over JdkA2AHttpClient (priority 0) by default.
  • Refactoring for Factory Usage: Updated various modules (client/base, client/transport/jsonrpc, client/transport/rest, server-common, http-client) to use the new A2AHttpClientFactory for client instantiation, promoting consistency and modularity.
  • New Module and Comprehensive Testing: A new http-client-vertx module was created, complete with unit, integration, and SSE-specific tests to ensure the robustness and correctness of the Vert.x implementation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ehsavoie
Copy link
Collaborator Author

@brasseld It has been quite some time but if you want to take a look at this PR :)

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a pluggable HTTP client architecture using Java's ServiceLoader, with a new Vert.x implementation and a JDK fallback. The changes are well-integrated across the codebase, updating dependencies, imports, and client instantiation to leverage the new A2AHttpClientFactory. The new Vert.x client and its provider are well-documented and include comprehensive tests. The overall design significantly improves flexibility by allowing users to choose or provide their preferred HTTP client implementation.

@ehsavoie ehsavoie force-pushed the vertx branch 2 times, most recently from bf5b44b to ed6d055 Compare January 13, 2026 14:40
Introduce ServiceLoader-based A2AHttpClient client architecture with two implementations:
- JDK HttpClient (core, always available)
- Vert.x WebClient (optional, high-performance)

Changes:
- Create http-client-vertx module for Vert.x implementation
- Add ServiceLoader infrastructure (A2AHttpClientFactory, providers)
- Update dependent modules to use Vert.x client by default
- Add comprehensive tests and usage examples

Users can choose implementation via Maven dependencies.
Priority-based selection: Vert.x (100) > JDK (0).

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Provide another other A2AHttpClient implementation

2 participants