Skip to content

🎨 Palette: Add tooltips to Topbar navigation icons #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aarjava wants to merge 3 commits into
base: main
Choose a base branch
from
Open

🎨 Palette: Add tooltips to Topbar navigation icons #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a7a448
🎨 Palette: Add tooltips to Topbar navigation icons
google-labs-jules[bot] Mar 27, 2026
a5a2fda
🎨 Palette: Add tooltips to Topbar navigation icons
google-labs-jules[bot] Mar 27, 2026
61b1cfc
🎨 Palette: Add tooltips to Topbar navigation icons
google-labs-jules[bot] Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Palette Journal

## 2025-03-27 - Nesting Triggers with Radix UI Tooltips and Dropdown Menus
**Learning:** When adding tooltips to an element that is already a Radix UI trigger (like a `DropdownMenuTrigger` in the Topbar), the combination of triggers must explicitly use `asChild` for proper event delegation.
**Action:** Strictly use the `asChild` prop at each intermediate trigger layer down to the final interactive element: `<TooltipTrigger asChild>` -> `<DropdownMenuTrigger asChild>` -> `<Button>`. This maintains accessibility and ensures both the tooltip and dropdown operate smoothly.
118 changes: 68 additions & 50 deletions src/components/nav/topbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
DropdownMenuSeparator,
DropdownMenuTrigger,
} from '@/components/ui/dropdown-menu'
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip'

export function Topbar() {
return (
Expand Down Expand Up @@ -52,59 +53,76 @@ export function Topbar() {

{/* Right Side - Actions */}
<div className="flex items-center gap-2">
{/* Notifications */}
<Button
variant="ghost"
size="icon"
className="text-neutral-medium hover:text-[var(--foreground)] hover:bg-[var(--surface)] transition-colors duration-150"
aria-label="Notifications"
>
<Bell className="size-4" />
</Button>
<TooltipProvider>
{/* Notifications */}
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="icon"
className="text-neutral-medium hover:text-[var(--foreground)] hover:bg-[var(--surface)] transition-colors duration-150"
aria-label="Notifications"
>
<Bell className="size-4" />
</Button>
</TooltipTrigger>
<TooltipContent>Notifications</TooltipContent>
</Tooltip>

{/* User Menu */}
<DropdownMenu>
<DropdownMenuTrigger asChild>
<Button
variant="ghost"
size="icon"
className="text-neutral-medium hover:text-[var(--foreground)] hover:bg-[var(--surface)] transition-colors duration-150"
aria-label="User menu"
{/* User Menu */}
<DropdownMenu>
<Tooltip>
<TooltipTrigger asChild>
<DropdownMenuTrigger asChild>
<Button
variant="ghost"
size="icon"
className="text-neutral-medium hover:text-[var(--foreground)] hover:bg-[var(--surface)] transition-colors duration-150"
aria-label="User menu"
>
<User className="size-4" />
</Button>
</DropdownMenuTrigger>
</TooltipTrigger>
<TooltipContent>User menu</TooltipContent>
</Tooltip>
<DropdownMenuContent
align="end"
className="bg-[var(--background)] border border-[var(--border)] text-[var(--foreground)]"
>
<User className="size-4" />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent
align="end"
className="bg-[var(--background)] border border-[var(--border)] text-[var(--foreground)]"
>
<DropdownMenuLabel className="text-[var(--foreground)]">My Account</DropdownMenuLabel>
<DropdownMenuSeparator className="bg-[var(--border)]" />
<DropdownMenuItem className="text-[var(--foreground)] hover:bg-[var(--surface)]">
Profile
</DropdownMenuItem>
<DropdownMenuItem className="text-[var(--foreground)] hover:bg-[var(--surface)]">
Settings
</DropdownMenuItem>
<DropdownMenuSeparator className="bg-[var(--border)]" />
<DropdownMenuItem className="text-[var(--foreground)] hover:bg-[var(--surface)]">
Logout
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
<DropdownMenuLabel className="text-[var(--foreground)]">My Account</DropdownMenuLabel>
<DropdownMenuSeparator className="bg-[var(--border)]" />
<DropdownMenuItem className="text-[var(--foreground)] hover:bg-[var(--surface)]">
Profile
</DropdownMenuItem>
<DropdownMenuItem className="text-[var(--foreground)] hover:bg-[var(--surface)]">
Settings
</DropdownMenuItem>
<DropdownMenuSeparator className="bg-[var(--border)]" />
<DropdownMenuItem className="text-[var(--foreground)] hover:bg-[var(--surface)]">
Logout
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>

{/* Settings Link */}
<Button
variant="ghost"
size="icon"
className="text-neutral-medium hover:text-[var(--foreground)] hover:bg-[var(--surface)] transition-colors duration-150"
aria-label="Settings"
asChild
>
<a href="/settings">
<SettingsIcon className="size-4" />
</a>
</Button>
{/* Settings Link */}
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="ghost"
size="icon"
className="text-neutral-medium hover:text-[var(--foreground)] hover:bg-[var(--surface)] transition-colors duration-150"
aria-label="Settings"
asChild
>
<a href="/settings">
<SettingsIcon className="size-4" />
</a>
</Button>
</TooltipTrigger>
<TooltipContent>Settings</TooltipContent>
</Tooltip>
</TooltipProvider>
</div>
</header>
)
Expand Down
Loading