Skip to content

🎨 Palette: Add accessible tooltip to department threshold delete button#139

Open
aarjava wants to merge 4 commits intomainfrom
palette/settings-tabs-tooltip-619327995427137314
Open

🎨 Palette: Add accessible tooltip to department threshold delete button#139
aarjava wants to merge 4 commits intomainfrom
palette/settings-tabs-tooltip-619327995427137314

Conversation

@aarjava
Copy link
Copy Markdown
Owner

@aarjava aarjava commented Mar 31, 2026

💡 What: Added a standard Shadcn Tooltip wrapper and an aria-label to the icon-only "Delete" button for department thresholds in SettingsTabs.tsx. Also added aria-hidden="true" to the decorative Trash2 icon.

🎯 Why: Icon-only buttons without accessible names or visible tooltips create significant barriers for screen reader users and can be ambiguous for sighted users. This ensures the action is clear and accessible.

📸 Before/After: Before, the button was a raw <Button> with just an icon. Now it displays "Remove department threshold" on hover and provides the same label to assistive tech.

♿ Accessibility: Added aria-label for screen reader announcement, aria-hidden="true" to prevent redundant reading of the decorative icon, and a visual tooltip for mouse/keyboard focus users.


PR created automatically by Jules for task 619327995427137314 started by @aarjava

Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fluxlens-ai Ready Ready Preview, Comment Mar 31, 2026 11:04pm

@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Co-authored-by: aarjava <218419324+aarjava@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant