fix(cli): narrow axios response headers to string at use sites#361
Merged
Conversation
Axios types response `headers[x]` as the union `string | number | true | string[] | AxiosHeaders`, but actual HTTP responses always return strings. Three call sites called `.includes(...)` or passed the value to `parseInt`, which fails type-checking under the broader union. Cast to `string | undefined` at each boundary. Pre-existing failure in TypeScript Build Check, unblocks CI for downstream PRs (action-layer refactor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three call sites in the CLI access response headers with
.includes(...)orparseInt(...):cli/src/api/client.ts— Content-Disposition match, Content-Type sniff, Content-Length parsecli/src/cli/config.ts— Content-Type sniff for API discoverycli/src/cli/login.ts— same Content-Type sniffAxios types
response.headers[x]asstring | number | true | string[] | AxiosHeaders, but HTTP responses always return strings. The broader union breaks type-checking. Cast tostring | undefinedat each boundary.Why now
Pre-existing TypeScript Build Check failure on main (seen on PR #360 V2 merge). Unblocks CI for the upcoming exploration-action-layer refactor PR.
Risk
Zero behavioral change — all sites already assumed string semantics at runtime.