fix: Admin API health check, Slack streaming errors, App Home graceful degradation#6
Open
aaronwong1989 wants to merge 2 commits into
Open
fix: Admin API health check, Slack streaming errors, App Home graceful degradation#6aaronwong1989 wants to merge 2 commits into
aaronwong1989 wants to merge 2 commits into
Conversation
…go#337) When PublishViewContext returns "not_enabled" (App Home feature not enabled in Slack App config), log at INFO level and return nil instead of ERROR. Applies to both HandleHomeOpened and HandleHomeRefresh. fix(chatapps): downgrade AppendStream ERROR to WARN for recoverable stream state (Refs hrygo#336) message_not_in_streaming_state is a recoverable condition handled by the streaming writer's fallback mechanism. Downgrade from ERROR to WARN to avoid alarming operators while preserving diagnostics. fix(cmd): replace admin port check with HTTP health check in doctor (Refs hrygo#335) Replace netcat-based port availability check with actual HTTP request to /admin/v1/health. This properly detects whether the Admin API is responding, not just whether the port is open. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use defer func() { _ = resp.Body.Close() }() to explicitly ignore
the close error, satisfying the errcheck linter.
Refs hrygo#335
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 independent bugs:
nc -zport check with actual HTTP request to/admin/v1/health.AppendStreamERROR to WARN formessage_not_in_streaming_state.not_enabled→ INFO log + nil return).Changes
chatapps/slack/apphome/handler.go—isAppHomeNotEnabled()+ graceful handlingchatapps/slack/messages.go— Conditional WARN/ERROR inAppendStreamcmd/hotplexd/cmd/doctor.go—checkAdminAPIHealth()HTTP health checkTest plan
go build ./...passesgo test ./...all passgolangci-lintpassesResolves hrygo#335
Resolves hrygo#336
Resolves hrygo#337
🤖 Generated with Claude Code