Sealed dumps: always-on v2 fingerprint (policy + runtime)#58
Merged
Conversation
Add --emit-seal-line to prefix output with a SQL comment encoding format version, Dumpling semver, security profile, and SHA-256 of canonical resolved policy JSON. Add --trust-sealed-dumps to pass the remainder of the file through unchanged when the first line matches the current binary, profile, and fingerprint. Reject --strict-coverage with a matching seal (no CREATE TABLE scan). Document in README and add an integration test. Co-authored-by: Andy Babic <ababic@users.noreply.github.com>
- Remove --emit-seal-line and --trust-sealed-dumps; seal is written on every non-check output and matching seals always enable passthrough - Bump seal payload to v=2; hash includes policy plus runtime params (format, sorted include/exclude patterns, PRNG seed override in standard) - Strip a non-matching leading seal so re-runs after config/flag changes do not duplicate seal lines - Add prng_seed_override_for_fingerprint() for seal vs hardened behavior Co-authored-by: Andy Babic <ababic@users.noreply.github.com>
a0fd5bd to
80da65a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebased onto current
main. Sealed dumps are always on (no CLI flags).Behaviour
--check) prefixes output with:-- dumpling-seal: v=2 version=<semver> profile=<standard|hardened> sha256=<64 hex>sha256): Canonical JSON includes Dumpling version, security profile, resolved policy (rules, filters, column cases, sensitive columns, output scan, salt), plus runtime fields:--format, sorted--include-table/--exclude-table, and PRNG seed override (--seed/DUMPLING_SEED) in standard profile only (nullin hardened where seeds are ignored at runtime).--strict-coveragestill errors when a matching seal would skip CREATE TABLE scanning.--check: No seal line written (no output file).Commits
mainafter ci: bump actions/checkout, setup-python, artifacts, Pages to Node 24 majors #57).Tests
cargo fmt,cargo clippy --all-targets --all-features,cargo test --all-targets --all-features.Slack Thread