feat: Enhance UI with semester-picker, CourseSettings, and color palette#190
Merged
abc873693 merged 5 commits intoMay 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the course settings UI by replacing the settings dialog and palette picker with a new CourseSettings bottom sheet. It introduces the 'Luster' color palette (with light and dark variants), updates localization strings for shorter schedule titles and semester names, and adds support for short semester names in the SemesterPicker. Additionally, CourseScaffold now supports showSearchButton and semesterPickerUiConfig. Feedback was provided regarding an inconsistency in CourseSettings where the initialChildSize calculation logic does not match the palette selector's visibility condition.
…dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
abc873693
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and feature additions to the course UI and localization system. The main highlights include updating and adding short semester names in both English and Traditional Chinese, refining course-related terminology, and enhancing the
CourseScaffoldwidget with a new settings menu, improved palette selection workflow, and more flexible configuration options.Localization Updates
English and Traditional Chinese Locales:
UI and Scaffold Enhancements
CourseScaffold and Settings:
ApIcon.menu) that opens a comprehensive settings dialog (CourseSettings.show). This dialog allows users to change the course palette and toggle additional course display options, streamlining the user experience. [1] [2] [3]_applyPickedPalette) for better maintainability.semesterPickerUiConfigparameter. [1] [2] [3] [4]showSearchButtonconfiguration toCourseConfigfor greater flexibility.General Improvements:
course_settings.dartwidget for broader use.These changes collectively enhance both the localization coverage and the configurability of the course UI, making it more user-friendly and easier to maintain.