Skip to content

⚡ Bolt: Vectorize path sanitization to eliminate per-group string manipu (salvages #178)#191

Open
abhimehro wants to merge 1 commit into
mainfrom
cursor-agent/salvage-seatek-178-bolt-vectorize-path-sanitiz-20260519-seatek-batch1
Open

⚡ Bolt: Vectorize path sanitization to eliminate per-group string manipu (salvages #178)#191
abhimehro wants to merge 1 commit into
mainfrom
cursor-agent/salvage-seatek-178-bolt-vectorize-path-sanitiz-20260519-seatek-batch1

Conversation

@abhimehro
Copy link
Copy Markdown
Owner

Salvage of #178

Rebased on main (Seatek batch 1).

Salvages: #178

…vages #178)

Refs: #178

LiveReview Pre-Commit Check: skipped (iter:1, coverage:0%)
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented May 19, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@cursor
Copy link
Copy Markdown

cursor Bot commented May 19, 2026

PR Summary

Low Risk
Low risk performance refactor that preserves existing path-traversal sanitization but changes where sanitized values are computed/consumed; main risk is mismatched column expectations if downstream code assumes the old outliers_df schema.

Overview
Precomputes sanitized safe_sheet and safe_next_year fields in prepare_outliers_df using vectorized string operations, and carries these columns through the empty-DataFrame case.

Updates apply_corrections to use the precomputed sanitized values instead of re-sanitizing per grouped sheet, reducing repeated string manipulation while keeping the same corrected output filename construction.

Reviewed by Cursor Bugbot for commit cb65c46. Configure here.

Copy link
Copy Markdown

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
6 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@abhimehro abhimehro marked this pull request as ready for review May 19, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants