Skip to content

⚡ Bolt: Optimize deduplication in push_rules #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhimehro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Optimize deduplication in push_rules #788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2193,7 +2193,12 @@ def push_rules(
if not existing_rules:
unique_hostnames_dict = dict.fromkeys(hostnames)
else:
unique_hostnames_dict = {h: None for h in hostnames if h not in existing_rules}
# ⚡ Bolt: Deduplicate hostnames before filtering against existing_rules.
# This significantly reduces redundant hash map lookups for inputs with
# many duplicates, yielding up to a 3x speedup on this comprehension step.
unique_hostnames_dict = {
h: None for h in dict.fromkeys(hostnames) if h not in existing_rules
}
Comment on lines +2196 to +2201
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Functional equivalence of deduplication reorder confirmed

The old code {h: None for h in hostnames if h not in existing_rules} and the new code {h: None for h in dict.fromkeys(hostnames) if h not in existing_rules} produce identical dictionaries. In both cases, the output contains exactly the unique hostnames from the input that are not in existing_rules, preserving first-occurrence order. The intermediate dict.fromkeys(hostnames) just removes duplicates earlier so that each unique hostname is only checked once against existing_rules. The downstream duplicates_count at main.py:2223 (original_count - len(filtered_hostnames) - skipped_unsafe) is unaffected because original_count still reflects the raw input length, and filtered_hostnames/skipped_unsafe derive from unique_hostnames_dict which has the same contents either way.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +2199 to +2201

# Optimization 2: Inline method references for hot loop performance
is_safe = _ALLOWED_RULE_CHARS.issuperset
Expand Down
Loading