Skip to content

[DX-981] Upgrade @ably/chat to v1.3.1 and remove msgpack workaround #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umair-ably merged 2 commits into from
Mar 26, 2026
+25 −35
Merged

[DX-981] Upgrade @ably/chat to v1.3.1 and remove msgpack workaround #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7231f8
Upgrade @ably/chat to v1.3.1 and remove useBinaryProtocol workaround
umair-ably Mar 26, 2026
0fcd0ea
Bump jsonwebtoken from ^9.0.2 to ^9.0.3 for Node 25 compatibility
umair-ably Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2038,6 +2038,8 @@ EXAMPLES

$ ably channels presence update my-channel --data '{"status":"busy"}' --json

$ ably channels presence update my-channel --data '{"status":"busy"}' --pretty-json

$ ably channels presence update my-channel --data '{"status":"online"}' --duration 60
```

Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
}
},
"dependencies": {
"@ably/chat": "^1.0.0",
"@ably/chat": "^1.3.1",
"@ably/spaces": "^0.4.0",
"@inquirer/prompts": "^5.1.3",
"@oclif/core": "^4.2.10",
Expand All @@ -125,7 +125,7 @@
"color-json": "^3.0.5",
"fast-levenshtein": "^3.0.0",
"inquirer": "^9.2.16",
"jsonwebtoken": "^9.0.2",
"jsonwebtoken": "^9.0.3",
"node-fetch": "^3.3.2",
"open": "^10.1.0",
"ora": "^8.2.0",
Expand Down
42 changes: 21 additions & 21 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 0 additions & 12 deletions src/chat-base-command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type * as Ably from "ably";
import { ChatClient, Room, RoomStatus } from "@ably/chat";

import { AblyBaseCommand } from "./base-command.js";
Expand All @@ -17,17 +16,6 @@ export abstract class ChatBaseCommand extends AblyBaseCommand {
private _chatClient: ChatClient | null = null;
private _cleanupTimeout: NodeJS.Timeout | undefined;

/**
* Override getClientOptions to disable binary protocol for Chat commands.
* The Chat API uses realtime.request() for REST calls, and binary (MsgPack)
* encoding is not supported by the Chat API endpoints.
*/
protected override getClientOptions(flags: BaseFlags): Ably.ClientOptions {
const options = super.getClientOptions(flags);
options.useBinaryProtocol = false;
return options;
}

/**
* finally disposes of the chat client, if there is one, which includes cleaning up any subscriptions.
*
Expand Down
Loading