Skip to content

fix: move serializer initialization inside methods #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttypic merged 1 commit into from
Jul 17, 2025
Merged

fix: move serializer initialization inside methods #1125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/main/java/io/ably/lib/objects/LiveObjectsHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public static LiveObjectSerializer getLiveObjectSerializer() {
} catch (ClassNotFoundException | InstantiationException | IllegalAccessException |
NoSuchMethodException |
InvocationTargetException e) {
Log.e(TAG, "Failed to init LiveObjectSerializer, LiveObjects plugin not included in the classpath", e);
Log.w(TAG, "Failed to init LiveObjectSerializer, LiveObjects plugin not included in the classpath", e);
return null;
}
}
Expand Down
3 changes: 2 additions & 1 deletion lib/src/main/java/io/ably/lib/objects/LiveObjectsJsonSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@

public class LiveObjectsJsonSerializer implements JsonSerializer<Object[]>, JsonDeserializer<Object[]> {
private static final String TAG = LiveObjectsJsonSerializer.class.getName();
private final LiveObjectSerializer serializer = LiveObjectsHelper.getLiveObjectSerializer();

@Override
public Object[] deserialize(JsonElement json, Type typeOfT, JsonDeserializationContext context) throws JsonParseException {
LiveObjectSerializer serializer = LiveObjectsHelper.getLiveObjectSerializer();
if (serializer == null) {
Log.w(TAG, "Skipping 'state' field json deserialization because LiveObjectsSerializer not found.");
return null;
Expand All @@ -29,6 +29,7 @@ public Object[] deserialize(JsonElement json, Type typeOfT, JsonDeserializationC

@Override
public JsonElement serialize(Object[] src, Type typeOfSrc, JsonSerializationContext context) {
LiveObjectSerializer serializer = LiveObjectsHelper.getLiveObjectSerializer();
if (serializer == null) {
Log.w(TAG, "Skipping 'state' field json serialization because LiveObjectsSerializer not found.");
return JsonNull.INSTANCE;
Expand Down
Loading