Conversation
WalkthroughThe changes update version references from 1.2.53 (or 1.2.22 in some documentation) to 1.2.54 across documentation, configuration, and a test file. The changelog is updated with a new entry for 1.2.54, and test assertions are adjusted to match the new version string. No functional code or API changes are present. Changes
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
CONTRIBUTING.md (1)
218-219: Avoid hard-coding the AAR filenameThe snippet now embeds the literal version (
1.2.54).
Using a placeholder (for exampleably-android-${ABLY_VERSION}.aar) keeps the docs evergreen and avoids touch-ups every release.lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1)
90-92: Hard-coded agent string makes the test brittleEvery version bump requires a manual patch here.
Consider deriving the expected value from the same constant used in production code, e.g.:-Collections.singletonList("ably-java/1.2.54 jre/" + System.getProperty("java.version"))); +Collections.singletonList( + Defaults.ABLY_AGENT_VERSION + " jre/" + System.getProperty("java.version")));This keeps the test self-maintaining across releases.
README.md (2)
54-55: Synchronise version string automaticallySimilar to the earlier comment for
CONTRIBUTING.md, embedding the literal version (1.2.54) means another manual edit next time.
If feasible, point readers to the Maven badge above or use a placeholder variable.
61-62: Gradle snippet – keep dependency line alignedMinor: move the SLF4J line under the Ably dependency for readability or add a blank line between different groups.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
CHANGELOG.md(1 hunks)CONTRIBUTING.md(1 hunks)README.md(2 hunks)gradle.properties(1 hunks)lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java(1 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
gradle.properties (1)
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1)
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
CONTRIBUTING.md (1)
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
README.md (3)
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
Learnt from: sacOO7
PR: ably/ably-java#1095
File: live-objects/src/test/kotlin/io/ably/lib/objects/integration/setup/IntegrationTest.kt:87-89
Timestamp: 2025-06-06T09:28:12.298Z
Learning: The Sandbox.kt file in ably-java live-objects module already has comprehensive HTTP retry mechanism using HttpRequestRetry with 5 retries, exponential backoff, and automatic retry on non-success responses and timeout exceptions.
Learnt from: sacOO7
PR: ably/ably-java#1092
File: live-objects/src/test/kotlin/io/ably/lib/objects/TestUtils.kt:21-32
Timestamp: 2025-06-03T09:15:15.338Z
Learning: In test utility code for the Ably Java Live Objects module, the team prefers to keep reflection-based field access utilities simple without additional error handling, allowing tests to fail fast if incorrect field names are used.
CHANGELOG.md (1)
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
🪛 markdownlint-cli2 (0.17.2)
README.md
58-58: Trailing punctuation in heading
Punctuation: ':'
(MD026, no-trailing-punctuation)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: check-rest
- GitHub Check: check-realtime
- GitHub Check: check-rest-okhttp
- GitHub Check: check-liveobjects
- GitHub Check: check-realtime-okhttp
- GitHub Check: check (21)
- GitHub Check: check (19)
- GitHub Check: check (24)
- GitHub Check: check (29)
- GitHub Check: build
- GitHub Check: check
🔇 Additional comments (3)
gradle.properties (1)
2-2: No stale version references detected – version bump to 1.2.54 is in syncThe
VERSION_NAMEin gradle.properties has been correctly updated to 1.2.54 and there are no remaining hard-coded occurrences of the previous 1.2.53 in the codebase (the only matches are in CHANGELOG.md, which intentionally reference past versions).
Defaults.ABLY_AGENT_VERSIONderives fromBuildConfig.VERSION(which pulls from gradle.properties), so the agent header will automatically use 1.2.54 at runtime.CHANGELOG.md (1)
3-13: Changelog entry looks goodEntry follows existing format and links are correct.
README.md (1)
120-121: Runtime-only dependency versionGood catch updating the OkHttp runtime module; looks consistent with the main artifact.
2 participants
Release 1.2.54
Summary by CodeRabbit
Documentation
Chores
Tests