chore: update Maven Publish plugin and fix publishing configuration#1128
chore: update Maven Publish plugin and fix publishing configuration#1128
Conversation
From 30 June `S01` and `oss.sonatype.com` are migrated to the `central.sonatype.com`
WalkthroughThe changes update the Changes
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
gradle.properties (1)
18-18: Add a short inline comment for future maintainersA one-liner explaining why this toggle exists prevents accidental deletion later.
-mavenCentralPublishing=true +mavenCentralPublishing=true # enables publishing to central.sonatype.com via plugin 0.34+
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
build.gradle.kts(0 hunks)gradle.properties(1 hunks)gradle/libs.versions.toml(1 hunks)
💤 Files with no reviewable changes (1)
- build.gradle.kts
🧰 Additional context used
🧠 Learnings (2)
gradle.properties (1)
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
gradle/libs.versions.toml (1)
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
🔇 Additional comments (1)
gradle/libs.versions.toml (1)
18-18: Version bump LGTMUpgrading
com.vanniktech.maven.publishto0.34.0is in line with the new Central Portal endpoints and is compatible with Gradle 8.x. No issues spotted.
From 30 June
S01andoss.sonatype.comare migrated to thecentral.sonatype.comSummary by CodeRabbit