Skip to content

chore: update Maven Publish plugin and fix publishing configuration#1128

Merged
ttypic merged 1 commit intomainfrom
fix-publishing
Jul 22, 2025
Merged

chore: update Maven Publish plugin and fix publishing configuration#1128
ttypic merged 1 commit intomainfrom
fix-publishing

Conversation

@ttypic
Copy link
Copy Markdown
Contributor

@ttypic ttypic commented Jul 18, 2025

From 30 June S01 and oss.sonatype.com are migrated to the central.sonatype.com

Summary by CodeRabbit

  • Chores
    • Updated the version of the Maven publishing plugin.
    • Added a new configuration property for Maven Central publishing.
    • Adjusted publishing settings to streamline configuration.

From 30 June `S01` and `oss.sonatype.com` are migrated to the `central.sonatype.com`
@ttypic ttypic requested a review from sacOO7 July 18, 2025 16:34
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Jul 18, 2025

Walkthrough

The changes update the maven-publish plugin version, remove explicit Sonatype publishing configuration from the Gradle build script, and introduce a new property for Maven Central publishing in the Gradle properties file. No exported or public entity declarations are affected.

Changes

File(s) Change Summary
build.gradle.kts Removed import and configuration for SonatypeHost and its usage.
gradle.properties Added mavenCentralPublishing=true property.
gradle/libs.versions.toml Updated maven-publish version from 0.30.0 to 0.34.0.

Suggested reviewers

  • sacOO7

Poem

In the warren where builds hop along,
A version update sings a stronger song.
Sonatype’s path is now less dense,
With properties set, it all makes sense!
The bunnies cheer as the plugins grow,
Publishing made simpler—off we go! 🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-publishing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
gradle.properties (1)

18-18: Add a short inline comment for future maintainers

A one-liner explaining why this toggle exists prevents accidental deletion later.

-mavenCentralPublishing=true
+mavenCentralPublishing=true # enables publishing to central.sonatype.com via plugin 0.34+
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59cb308 and eff6b05.

📒 Files selected for processing (3)
  • build.gradle.kts (0 hunks)
  • gradle.properties (1 hunks)
  • gradle/libs.versions.toml (1 hunks)
💤 Files with no reviewable changes (1)
  • build.gradle.kts
🧰 Additional context used
🧠 Learnings (2)
gradle.properties (1)
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
gradle/libs.versions.toml (1)
Learnt from: sacOO7
PR: ably/ably-java#1095
File: gradle/libs.versions.toml:24-26
Timestamp: 2025-06-05T10:27:53.946Z
Learning: The ably-java project prefers to use the latest available versions of testing dependencies (including pre-release versions) when they contain relevant bug fixes, rather than sticking strictly to stable releases.
🔇 Additional comments (1)
gradle/libs.versions.toml (1)

18-18: Version bump LGTM

Upgrading com.vanniktech.maven.publish to 0.34.0 is in line with the new Central Portal endpoints and is compatible with Gradle 8.x. No issues spotted.

Copy link
Copy Markdown
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ttypic ttypic merged commit 86e2dac into main Jul 22, 2025
13 checks passed
@ttypic ttypic deleted the fix-publishing branch July 22, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants