test: verify PUT with msgpack body works against Chat API#2186
Closed
umair-ably wants to merge 1 commit intomainfrom
Closed
test: verify PUT with msgpack body works against Chat API#2186umair-ably wants to merge 1 commit intomainfrom
umair-ably wants to merge 1 commit intomainfrom
Conversation
Add a test that sends a chat message (POST) then updates it (PUT), both via rest.request(), running on both JSON and msgpack protocols via testOnJsonMsgpack. This tests the full request path through infrastructure to verify that Content-Type and body encoding are preserved for PUT requests with msgpack. If this test passes but the equivalent chat-js test fails, the issue is in how chat-js calls realtime.request(). If both fail, the issue is infrastructure-level.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_chat_put_msgpacktest that sends a chat message (POST) then updates it (PUT), both viarest.request()testOnJsonMsgpackContext
The Chat SDK's integration tests show that
messages.update()(PUT) fails with "cannot decode request body" whenuseBinaryProtocol: true, whilemessages.send()(POST) works fine. See: ably/ably-chat-js#721This test isolates whether the issue is in ably-js's
request()method or in how chat-js calls it:Companion PRs:
Test plan
request_chat_put_msgpackpasses with both JSON and msgpack protocols