Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cb8ca2d to
7bbf38b
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
7bbf38b to
9b4f86d
Compare
splindsay-92
left a comment
There was a problem hiding this comment.
Before I start the review, I checked the ticket which states this is a Getting started guide for NextJS and React using Pub/Sub. Is this guide supposed to just be a NextJS with plain ably-js, is there a NextJS + React coming too? :)
Oops, that's where lack of experience in platforms can bite. I wasn't aware that it's possible to use ably differently with NextJS (plain and hooks) to even ask this question. And now I'm not sure whether it worth two separate guides or put second set of code blocks into the same guide or go solo on hooks variant. WDYT @m-hulbert @splindsay-92 |
No worries at all! If you checkout https://github.com/ably/ably-nextjs-fundamentals-kit, this shows best practice for using ably-js react hooks and providers with NextJS (there are some gotchas which is why we put this together) :) My personal opinion is that a common use-case is Vercel + NextJS + React as a stack, so it would be good to either have a built example app or a guide for NextJs + React at least :) |
|
I think we should have them as standalone guides rather than trying to mix languages in the getting started ones. As Steven says, React + NextJS has a few things that trip people up, so I think it would be worth updating to use hooks if you don't mind @maratal |
Description
Getting started guide for NextJS and React using Pub/Sub.
https://ably.atlassian.net/browse/DX-531
Checklist