ADD RTL3d1 requiring channel state transitions to happen before the connected event#442
Merged
SimonWoolf merged 1 commit intomainfrom Mar 24, 2026
Merged
ADD RTL3d1 requiring channel state transitions to happen before the connected event#442SimonWoolf merged 1 commit intomainfrom
SimonWoolf merged 1 commit intomainfrom
Conversation
…onnected event This ensures that when a connection listener observes the `CONNECTED` state, channels that were previously `ATTACHED` are already in the `ATTACHING` state. Without this ordering guarantee, a connection listener calling `attach()` on a channel per `RTL4a` would see the channel as `ATTACHED` and receive an immediate success callback without a server round-trip, potentially leading to operations (such as presence enter) being performed on a channel that in reality is not attached
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that when a connection listener observes the
CONNECTEDstate, channels that were previouslyATTACHEDare already in theATTACHINGstate. Without this ordering guarantee, a connection listener callingattach()on a channel perRTL4awould see the channel asATTACHEDand receive an immediate success callback without a server round-trip, potentially leading to operations (such as presence enter) being performed on a channel that in reality is not attached