Fix security advisories: postcss, @adonisjs/core, lodash-es#493
Merged
Fix security advisories: postcss, @adonisjs/core, lodash-es#493
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates several dependency versions and migrates the Prettier configuration from an external package to an inline definition in package.json. However, several critical issues were identified: the specified versions for postcss (8.5.13), @adonisjs/core (7.3.2), and lodash-es (4.18.1) do not exist on the npm registry, which will lead to installation failures and potential security risks. Furthermore, removing the Prettier configuration package disables formatting for .edge files; it is recommended to use dependency overrides to resolve security vulnerabilities while maintaining project formatting.
- Upgrade postcss 8.5.8 → 8.5.13 (fixes XSS via unescaped </style>) - Upgrade @adonisjs/core 7.0.1 → 7.3.2 (pulls @adonisjs/http-server with open redirect fix) - Override lodash-es to 4.18.1 (fixes code injection via _.template and prototype pollution via _.unset/_.omit). The vulnerable 4.17.23 is pinned by chevrotain@11 (transitive of prettier-plugin-edgejs); no upstream fix available yet.
tp-abtion
force-pushed
the
fix/security-advisories-2026-05-04
branch
from
38a6383 to
1eaee81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
</style>in CSS stringify output (GHSA-qx2v-qp2m-jg93)@adonisjs/http-server@^8.2.0which fixes the open redirect vulnerability (GHSA-6qvv-pj99-48qm)_.template(GHSA-r5fr-rjxr-66jc) and prototype pollution via_.unset/_.omit(GHSA-f23m-r3pf-42rh). The vulnerable 4.17.23 is pinned bychevrotain@11(transitive ofprettier-plugin-edgejs); no upstream fix available yet.Verification
npm auditreports 0 vulnerabilities