Add regression test for protocol treasury balance unchanged after fai…#379
Merged
Chucks1093 merged 1 commit intoMay 31, 2026
Conversation
…led trade When a trade fails, no fees should reach the protocol treasury. These tests record the read-only treasury balance before a trade expected to fail, trigger the failing trade, and assert the balance is identical afterward, confirming no partial fee transfer occurs on the error path. Covers a buy failure (InsufficientPayment, plus NotRegistered against a seeded non-zero treasury) and a sell failure (InsufficientBalance). Closes accesslayerorg#371
|
@Kingvic300 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…led trade
When a trade fails, no fees should reach the protocol treasury. These tests record the read-only treasury balance before a trade expected to fail, trigger the failing trade, and assert the balance is identical afterward, confirming no partial fee transfer occurs on the error path.
Covers a buy failure (InsufficientPayment, plus NotRegistered against a seeded non-zero treasury) and a sell failure (InsufficientBalance).
Closes #371
Summary
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceChecklist
CLoses: #371