Add zero-supply sell underflow test#384
Merged
Chucks1093 merged 1 commit intoMay 31, 2026
Merged
Conversation
|
@kitWarse Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sell_keyreturnsContractError::SellUnderflowinstead of panicking on arithmetic underflow, and verifies the failed call leaves observable state unchanged.Issue
Changes
creator-keys/tests/sell_underflow.rswith a distinct zero-supply creator sell test.capture_snapshotbefore and after the failed sell to assert supply, holder count, and seller key balance are unchanged.Validation
cargo fmt.git diff --check.cargo test -p creator-keys test_sell_registered_zero_supply_creator_returns_sell_underflow_without_state_change, but local compilation could not proceed because this Windows environment is missing the MSVC linkerlink.exebefore repo code compiled.Notes
kitWarse/accesslayer-contractsis a fork ofaccesslayerorg/accesslayer-contracts.