Add config masking helper, wallet address validation, and integration tests#413
Merged
Chucks1093 merged 1 commit intoJun 2, 2026
Conversation
… tests - Add maskSensitiveConfigValues() helper to redact secrets and credentials from startup config summary logs (accesslayerorg#300) - Add Stellar address format validation to requireCreatorProfileOwnership middleware, returning 400 for malformed wallet addresses (accesslayerorg#299) - Add integration test for creator list response shape consistency across page sizes of 1, 10, and 100 (accesslayerorg#317) - Add integration test for concurrent creator list requests returning consistent results (accesslayerorg#312) - Mount creator module routes in modules/index.ts so profile endpoints are accessible - Configure Jest roots to src/ to prevent stale dist test artifacts from interfering with test runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses 4 issues: config masking, wallet address validation, and two new integration test suites for the creator list endpoint.
Changes
Issue #300 — Config masking helper for startup summary log
src/utils/config-mask.utils.tswithmaskSensitiveConfigValues()that redacts values whose keys match sensitive patterns (SECRET,KEY,PASSWORD,TOKEN, andDATABASE_URL)DATABASE_URLhas its embedded credentials redactedserver.tsvia alogger.infocall with the masked configIssue #299 — Integration test for malformed wallet address param
requireCreatorProfileOwnershipmiddleware using the existingStellarAddressSchema(56 chars, starts withG, Base32)400with a standard error shapecreator-profile-protected.integration.test.tscovering wrong length, invalid characters, and valid addressescreator.routes.tsinmodules/index.tsso the profile endpoints are accessibleIssue #317 — Integration test for creator list response shape consistency
src/__tests__/integration/creator-list-response-shape.test.tsMAX_PAGE_SIZE(100)success,data.items,data.meta) is identical across all sizesitems.lengthmatches the requested page size and pagination metadata reflects the correctlimitandtotalIssue #312 — Integration test for concurrent creator list requests
src/__tests__/integration/creator-list-concurrent.test.tsGET /api/v1/creatorsrequestsInfrastructure
roots: ["<rootDir>/src"]to prevent staledist/test artifacts from interferingTesting
pnpm lintandpnpm buildpass cleanlyCloses #317
Closes #299
Closes #300
Closes #312