Proposal: Custom Linter#190
Open
GaballaGit wants to merge 1 commit into
Open
Conversation
GaballaGit
force-pushed
the
proposal/custom-linter
branch
from
5178ee3 to
246f818
Compare
godoc reference preview ready ✨
|
Collaborator
|
Sounds cool, ima take a look. If it's not too hard to implement maintain would be a good addition |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I was messing around with go/ast and had an idea we could make a custom linter for our project.
Why?
A custom linter can be useful for our projects to enforce architectural rules, for example here in this proposal I am enforcing the rule of no dbmodel imports in the api handlers. I think this will help future contributors follow architectural rules that they may not be aware off by getting caught in the ci first and reading about it possibly. The ci will fail if merged, which means it is currently working as intended.
It's pretty messy right now in the proposal state, but I want to put the idea out there for you all. Feel free to leave thoughts/comments/questions about it, Ill answer them.