-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Use ruby/setup-ruby@v1 in Ruby starter workflow #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Gpapi13
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I'm sorry @eregon I totally get the reasoning for this you aren't the first person to ask. It is a pain for everyone involved, but at this time we can't relax this restriction. We do have to do something to improve the story here and we know about this internally within the Actions team. I keep hoping at some point we can relax this, but for this moment the guidance that I'm following from security is to keep pinning to 40 char shas. I will go and check with the documentation team on that one, thanks for the pointer. Sorry once again, we'll get there. |
|
This pull request has become stale and will be closed automatically within a period of time. Sorry about that. |
|
I'm just tring to get info from 9312141228 and I don know I I did. Right or not |
| # uses: ruby/setup-ruby@v1 | ||
| uses: ruby/setup-ruby@473e4d8fe5dd94ee328fdfca9f8c9c7afc9dae5e | ||
| uses: ruby/setup-ruby@v1 | ||
| with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9312141228
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would do that and pay for it if you could give me some how to get number 9312141228File attached and everything without them knowing I will pay for that like still For two days now and I still have not satisfy my phone nothing just slowing my phone don and no info
I am the main author of ruby/setup-ruby.
I think it's time to simply use
@v1in this starter workflow.Even the official documentation about this action, by GitHub, uses
ruby/setup-ruby@v1:https://docs.github.com/en/actions/guides/building-and-testing-ruby
Probably the rule below merits updating:
Does that sound acceptable?
If people actually want maximum security and stability (at the expense of everything else), they should probably pin everything down to a full sha (also actions developed by GitHub, they depend on third party packages which might change and have new security issues), but that seems very extreme and inconvenient, so I guess extremely few users would do that, and if they do, they would be well aware to do it for all actions, not just "3rd-party" ones.
Previous discussions about this and how weird and problematic it is to recommend a full sha to people trying GitHub Actions: #448, #709 and probably more.
Starter workflows should make it easy to get started.
If they're more cumbersome to use than the snippets in the documentation, there seems to be a problem.