Add Ruby4.0 and Rails8.1 to the CI matrix#346
Merged
kbrock merged 2 commits intoactive-hash:masterfrom Apr 13, 2026
Merged
Conversation
also updated actions/checkout to the latest version.
kbrock
requested changes
Apr 11, 2026
Collaborator
kbrock
left a comment
kbrock
left a comment
There was a problem hiding this comment.
I'm currently only allowed to merge other people's code. Trying to get this fixed up.
If this looks good to you, could you change your pr for this?
6.1 7.0 7.1 7.2 8.0 8.1
3.0 X
3.1 X
3.2 X X
3.3 X
3.4 X X
4.0 X
Comment on lines
+33
to
+59
| ruby: ['3.0', '3.1', '3.2', '3.3', '3.4', '4.0'] | ||
| gemfile: | ||
| - 'gemfiles/rails_6.1.gemfile' | ||
| - 'gemfiles/rails_7.0.gemfile' | ||
| - 'gemfiles/rails_7.1.gemfile' | ||
| - 'gemfiles/rails_7.2.gemfile' | ||
| - 'gemfiles/rails_8.0.gemfile' | ||
| - 'gemfiles/rails_8.1.gemfile' | ||
| exclude: | ||
| - ruby: '3.0' | ||
| gemfile: 'gemfiles/rails_7.2.gemfile' | ||
| - ruby: '3.0' | ||
| gemfile: 'gemfiles/rails_8.0.gemfile' | ||
| - ruby: '3.0' | ||
| gemfile: 'gemfiles/rails_8.1.gemfile' | ||
| - ruby: '3.1' | ||
| gemfile: 'gemfiles/rails_8.0.gemfile' | ||
| - ruby: '3.1' | ||
| gemfile: 'gemfiles/rails_8.1.gemfile' | ||
| - ruby: '3.4' | ||
| gemfile: 'gemfiles/rails_6.1.gemfile' | ||
| - ruby: '3.4' | ||
| gemfile: 'gemfiles/rails_7.0.gemfile' | ||
| - ruby: '4.0' | ||
| gemfile: 'gemfiles/rails_6.1.gemfile' | ||
| - ruby: '4.0' | ||
| gemfile: 'gemfiles/rails_7.0.gemfile' |
Collaborator
There was a problem hiding this comment.
Due to review rules, could you make this edit and I can merge?
It doesn't make sense for us to test so many of these combinations for deprecated entries. I would like to test older ruby and gems, but not necessary for all these entries.
How about we go with the following?
include:
- { ruby: '3.0', gemfile: 'gemfiles/rails_6.1.gemfile' }
- { ruby: '3.1', gemfile: 'gemfiles/rails_7.0.gemfile' }
- { ruby: '3.2', gemfile: 'gemfiles/rails_7.1.gemfile' }
- { ruby: '3.2', gemfile: 'gemfiles/rails_7.2.gemfile' }
# Active Rails
- { ruby: '3.3', gemfile: 'gemfiles/rails_8.0.gemfile' }
- { ruby: '3.4', gemfile: 'gemfiles/rails_8.0.gemfile' }
- { ruby: '3.4', gemfile: 'gemfiles/rails_8.1.gemfile' }
- { ruby: '4.0', gemfile: 'gemfiles/rails_8.1.gemfile' }
kbrock
approved these changes
Apr 13, 2026
Collaborator
kbrock
left a comment
kbrock
left a comment
There was a problem hiding this comment.
Thank you for starting this
(and helping us get this new version in)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also updated actions/checkout to the latest version.