feat: Introduce new particle container to be used with Fatras and Examples#5210
Draft
andiwand wants to merge 2 commits intoacts-project:mainfrom
Draft
feat: Introduce new particle container to be used with Fatras and Examples#5210andiwand wants to merge 2 commits intoacts-project:mainfrom
andiwand wants to merge 2 commits intoacts-project:mainfrom
Conversation
github-actions
bot
added
Component - Core
Contributor
andiwand
force-pushed
the
fatras-new-particle-container
branch
from
ae7bc4b to
9d84587
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new concrete particle and hit container that is planned to be used for Fatras and Examples. It is similar to our existing track container and space point container with an extensible SoA-style layout.
This new container works with indices to identify particles and removes the dependency on a unique barcode. The barcode is now just a simple property of the particle. This makes handling of the container much easier and will also allow us to map it to Python very easily. Apart from that we can now also easily model the particle creation tree with a list of parent particles.
The plan is to migrate gradually to this new container as a single change would be too big. Bringing the container in and adding some tests without actually using it is the first step.
--- END COMMIT MESSAGE ---
A few more ideas we could consider:
blocked by
ContainerSubsetto arbitrary index container #5175