feat: muon buckets sector frame + bucket splitting by davidedicroce · Pull Request #5229 · acts-project/acts

davidedicroce · 2026-03-10T14:19:51Z

This MR introduces sector-based muon bucketization for the GeoModel mockup workflow and aligns the mockup geometry IDs so digitization can consistently resolve a common sector frame.

1. MuonSpacePointDigitizer:

Replaced chamber-frame helper with toSectorFrame() using a representative tracking volume.
Grouping changed from chamber-like IDs to sector IDs (volume-level key).
Added configurable bucket controls:
- bucketMaxWindow (max longitudinal extent)
- bucketNeighborWindow (max inter-point gap before split)
- bucketOverlapWindow (tail overlap copied to next bucket)
- minBucketSize (small buckets removed)
Implemented bucket split logic in sorted-z order per sector.
Added representative-volume resolution and caching per sector.

2. GeoModelMuonMockupBuilder:

Introduced sector parsing utilities from chamber names:
- integer extraction by underscore tokenization
- sector number extraction
- eta-side sign extraction
Added a SectorKey = (station, sector, etaSide) grouping.
Assigned tracking volume IDs per sector key with explicit counter and capacity checks.
Assigned layer blocks per chamber/child volume to avoid collisions and preserve sector-consistent IDs.
Updated processStation() API to pass station index and shared nextVolumeId.

3. Examples/Scripts/Python/geomodel_G4.py:

Added useful CLI knobs: dumpGeoModelDb, nSectors, nEtaStations, disableEndcaps

4. Examples/Detectors/MuonSpectrometerMockupDetector/src/GeoMuonMockupExperiment.cpp:

Switched from std::any_cast to std::get and updated exception handling to std::bad_variant_access to match current key type usage.

5. Python/Examples/src/Digitization.cpp:

Extended Python digitization binding to pass new bucketization window parameters.

@dimitra97 @junggjo9

Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp

Examples/Detectors/GeoModelDetector/src/GeoModelMuonMockupBuilder.cpp

...tectors/GeoModelDetector/include/ActsExamples/GeoModelDetector/GeoModelMuonMockupBuilder.hpp

…_access

…_access one more try

sonarqubecloud · 2026-03-10T18:44:03Z

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-03-10T18:57:58Z

📊: Physics performance monitoring for `27ca050`

Full contents

physmon summary

junggjo9 · 2026-03-10T14:58:15Z

Examples/Algorithms/Digitization/include/ActsExamples/Digitization/MuonSpacePointDigitizer.hpp

    double rpcDeadTime{50. * Acts::UnitConstants::ns};
+
+    /// @brief Maximum longitudinal extent of a bucket in the common sector frame
+    double bucketMaxWindow{800. * Acts::UnitConstants::mm};


Suggested change

double bucketMaxWindow{800. * Acts::UnitConstants::mm};

double bucketMaxWindow{80. * Acts::UnitConstants::cm};

junggjo9 · 2026-03-10T14:58:31Z

Examples/Algorithms/Digitization/include/ActsExamples/Digitization/MuonSpacePointDigitizer.hpp

+    double bucketNeighborWindow{200. * Acts::UnitConstants::mm};
+    /// @brief Tail overlap copied from the previous bucket into the next one
+    double bucketOverlapWindow{100. * Acts::UnitConstants::mm};


Suggested change

double bucketNeighborWindow{200. * Acts::UnitConstants::mm};

/// @brief Tail overlap copied from the previous bucket into the next one

double bucketOverlapWindow{100. * Acts::UnitConstants::mm};

double bucketNeighborWindow{20. * Acts::UnitConstants::cm};

/// @brief Tail overlap copied from the previous bucket into the next one

double bucketOverlapWindow{10. * Acts::UnitConstants::cm};

junggjo9 · 2026-03-11T12:18:52Z

Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp

 #include <algorithm>
+#include <cmath>
 #include <format>
+#include <iterator>


Suggested change

#include <iterator>

junggjo9 · 2026-03-11T12:19:35Z

Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp


+inline double bucketSigmaZ(const MuonSpacePoint& sp,
+                           const double sigmaScale = 1.) {
+  const auto cov = sp.covariance();


Suggested change

const auto cov = sp.covariance();

const& auto cov = sp.covariance();

junggjo9 · 2026-03-11T12:22:24Z

Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp

+  const double var0 = cov[0];
+  const double var1 = cov[1];
+  const double maxVar = std::max({0., var0, var1});
+  return sigmaScale * std::sqrt(maxVar);


Wait that's a bit edgy. The variances describe the measurement's uncertainty in x and y. How does this relate?

junggjo9 · 2026-03-11T12:34:02Z

Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp

+    if (trackingGeometry.findVolume(volId) != nullptr) {
+      return volId;


How is it possible that an invalid volume identifier is in the list?

junggjo9 · 2026-03-11T12:37:12Z

Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp

  MuonSpacePointCalibrator::Config calibCfg{};
  m_cfg.calibrator =
-      std::make_unique<MuonSpacePointCalibrator>(calibCfg, logger().clone());
+      std::make_shared<MuonSpacePointCalibrator>(calibCfg, logger().clone());


Suggested change

std::make_shared<MuonSpacePointCalibrator>(calibCfg, logger().clone());

std::make_unique<MuonSpacePointCalibrator>(calibCfg, logger().clone());

junggjo9 · 2026-03-31T13:45:08Z

Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp

+                      if (a.geometryId().layer() != b.geometryId().layer()) {
+                        return a.geometryId().layer() < b.geometryId().layer();
+                      }
+                      if (a.localPosition().z() != b.localPosition().z()) {
+                        return a.localPosition().z() < b.localPosition().z();
+                      }


Suggested change

if (a.geometryId().layer() != b.geometryId().layer()) {

return a.geometryId().layer() < b.geometryId().layer();

}

if (a.localPosition().z() != b.localPosition().z()) {

return a.localPosition().z() < b.localPosition().z();

}

if (a.localPosition().z() != b.localPosition().z()) {

return a.localPosition().z() < b.localPosition().z();

}

junggjo9 · 2026-03-31T13:46:00Z

Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp

+        }
+        return a.value() < b.value();
+      });
+  sortedIds.erase(std::unique(sortedIds.begin(), sortedIds.end()),


Suggested change

sortedIds.erase(std::unique(sortedIds.begin(), sortedIds.end()),

sortedIds.erase(std::ranges::unique(sortedIds),

davidedicroce added 5 commits March 9, 2026 15:41

fixing std get in GeoMuonMockupExperiment

38acc8a

First attempt to muon buckets à la Athena

4cfa86f

Muon bucketizer + adjusting tracking volume sorting

93099c9

logging back to info

da2f0fb

Merge branch 'main' into MuonBuckets

9b7436f

github-actions bot added the Component - Examples Affects the Examples module label Mar 10, 2026

Adding more pytest for geomodel_G4

4cc1d28

github-actions bot added this to the next milestone Mar 10, 2026

dimitra97 reviewed Mar 10, 2026

View reviewed changes

Examples/Algorithms/Digitization/src/MuonSpacePointDigitizer.cpp Outdated Show resolved Hide resolved

dimitra97 reviewed Mar 10, 2026

View reviewed changes

davidedicroce marked this pull request as draft March 10, 2026 15:45

Applying suggestions

ac576ef

davidedicroce changed the title ~~Muon buckets: sector frame + bucket splitting~~ feat: muon buckets sector frame + bucket splitting Mar 10, 2026

davidedicroce added 4 commits March 10, 2026 17:57

Fix bug related to std::get<std::string>(pubKey) and std::bad_variant…

5b3c141

…_access

Fix bug related to std::get<std::string>(pubKey) and std::bad_variant…

b3949bc

…_access

Fix bug related to std::get<std::string>(pubKey) and std::bad_variant…

4f89d47

…_access one more try

lint fix

27ca050

davidedicroce marked this pull request as ready for review March 10, 2026 20:29

andiwand requested a review from dimitra97 March 16, 2026 19:57

junggjo9 reviewed Mar 31, 2026

View reviewed changes

	double bucketMaxWindow{800. * Acts::UnitConstants::mm};
	double bucketMaxWindow{80. * Acts::UnitConstants::cm};

	const auto cov = sp.covariance();
	const& auto cov = sp.covariance();

		if (trackingGeometry.findVolume(volId) != nullptr) {
		return volId;

	std::make_shared<MuonSpacePointCalibrator>(calibCfg, logger().clone());
	std::make_unique<MuonSpacePointCalibrator>(calibCfg, logger().clone());

	sortedIds.erase(std::unique(sortedIds.begin(), sortedIds.end()),
	sortedIds.erase(std::ranges::unique(sortedIds),

Conversation

davidedicroce commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Mar 10, 2026

Quality Gate passed

Uh oh!

github-actions bot commented Mar 10, 2026

📊: Physics performance monitoring for 27ca050

physmon summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

davidedicroce commented Mar 10, 2026 •

edited

Loading

📊: Physics performance monitoring for `27ca050`