feat: Demonstrator for MillePede alignment of ACTS Kalman tracks#5256
Open
goblirsc wants to merge 14 commits intoacts-project:mainfrom
Open
feat: Demonstrator for MillePede alignment of ACTS Kalman tracks#5256goblirsc wants to merge 14 commits intoacts-project:mainfrom
goblirsc wants to merge 14 commits intoacts-project:mainfrom
Conversation
Contributor
Author
|
Wow, the CI even checks the PR title? |
Contributor
Contributor
|
Amazing! |
goblirsc
commented
Mar 20, 2026
Contributor
Author
|
Pausing updates for now to allow for review (sorry for the big PR - once the first bits were in place the extra features just kept coming by themselves 😇 ) |
SonarQube is an &*$% minor cosmetics
ff4d2f2 to
38176e7
Compare
|
Contributor
Author
Member
Contributor
|
It is also on my list but I didn't get to it yet. Let me also ping the review channel on MM https://mattermost.web.cern.ch/acts/channels/code-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Add a first demonstrator of MillePede alignment, using existing ACTS Kalman tracks.
--- END COMMIT MESSAGE ---
First step towards adding actual life to the MillePede ❤️ ACTS effort!
After making
Milleavailable as a plugin in we use it to write ACTS-Kalman tracks out into binary files that can be fit with the MillePede package.This path is simple (as we can re-use existing tracks), but computationally highly inefficient - we have to "undo" the track fit to bring the global covariance matrix of the Kalman tracks into the format expected by Millepede.
This should hence be seen as an initial proof of concept demonstrator.
For real-life usage, the
GeneralBrokenLinestrack refit (planned for ACTS-integration in the near future) will likely be a better choice for the fitter component in the alignment. But the final implementation should be sufficiently modular to work with any fitter nonetheless.In this MR, we add
Millebinaries, allowing to populate ACTSTrackAlignmentStates from Mille binariesAlignedTelescopeDetectorfor a simple showcase setupMillewriting and reading back into ACTS results in consistent alignment problemsThe alignment fit itself is performed outside ACTS using the MillePede package. Alternatively, it is possible to read the binaries back and solve using the ACTS tooling.