Skip to content

chore!: remove unused files part 2 #5282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AJPfleger wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore!: remove unused files part 2 #5282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26a1f35
rm
AJPfleger Mar 25, 2026
3f20c0d
Merge branch 'main' into rm-unused-files
AJPfleger Mar 25, 2026
a30e6ed
rm excluded files
AJPfleger Mar 25, 2026
f9b30c4
Merge branch 'main' into rm-unused-files
AJPfleger Apr 17, 2026
6452355
Delete docs/groups/detector_descr/runtime_geometry_modules.md
AJPfleger Apr 17, 2026
f25d837
Delete Core/include/Acts/Geometry/GeometryModule.h
AJPfleger Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions CI/check_unused_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,6 @@ def main():
"acts-version-manager.js",
"tex-mml-chtml.js",
"Python/conftest.py",
# Temporarily excluded files. TODO remove in next major release.
"Core/include/Acts/EventData/detail/ParameterTraits.hpp",
"Core/include/Acts/Seeding/PathSeeder.hpp",
"Tests/CommonHelpers/include/ActsTests/CommonHelpers/TestSpacePoint.hpp",
"GeometryModule.h",
"runtime_geometry_modules.md",
Comment on lines -78 to -79
Copy link
Copy Markdown
Contributor Author

@AJPfleger AJPfleger Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulgessinger, I saw you added these 2 files to be removed in the next breaking release with #5253. Is this correct?

Copy link
Copy Markdown
Member

@paulgessinger paulgessinger Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand what you mean here. I added the files in #5253, but they're still there and were flagged.

Copy link
Copy Markdown
Contributor Author

@AJPfleger AJPfleger Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are now labeled as Temporarily excluded files. TODO remove in next major release. I am wondering if the category is correct.

Copy link
Copy Markdown
Member

@paulgessinger paulgessinger Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah probably not. I suppose I didn't see it's that category.

)

suffix_header = (
Expand Down
175 changes: 0 additions & 175 deletions Core/include/Acts/EventData/detail/ParameterTraits.hpp
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions Core/include/Acts/Geometry/GeometryModule.h
View file
Open in desktop

This file was deleted.

189 changes: 0 additions & 189 deletions Core/include/Acts/Seeding/PathSeeder.hpp
View file
Open in desktop

This file was deleted.

Loading
Loading