ref: Merge parameter transporter and resetter to parameter updater#1105
Conversation
5533ba8 to
cb1b7f2
Compare
0765db4 to
cb4ee1b
Compare
98a3c56 to
9eb38cb
Compare
|
9eb38cb to
a751e9a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
a4eb739 to
2ffc40c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2ffc40c to
1454a0c
Compare
1c90b47 to
6a29182
Compare
|
Tested in acts-project/traccc#1244 |
Performance summaryHere is a summary of the performance effects of this PR: Tabular
Note This is an automated message produced upon the explicit request of a human being. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
6a29182 to
aae1765
Compare
aae1765 to
46bc383
Compare
46bc383 to
f9df282
Compare
stephenswat
left a comment
There was a problem hiding this comment.
Happy to accept a small slowdown here if it simplifies the code.
I thought this is a throughput increase, or am I reading the results wrong? |
68424b1 to
b2b8a40
Compare
You are correct I am dumb. |
b2b8a40 to
e25b845
Compare
|



Merge the parameter transporter and parameter resetter to a single composite actor, with any actor that relies on the bound track parameters as their observers. This way, actors like the material interactor cannot be added to the actor chain without the parameter updater present and the parameter resetter cannot be omitted by accident either without a compiler error.
The observing actors are now only triggered if the new actor result type sets a notify flag, making checking for the navigation to be on surface necessary only in the parameter updater.