Skip to content

ref: Merge parameter transporter and resetter to parameter updater#1105

Merged
niermann999 merged 1 commit intoacts-project:mainfrom
niermann999:ref-prevent-track-conversion
Apr 1, 2026
Merged

ref: Merge parameter transporter and resetter to parameter updater#1105
niermann999 merged 1 commit intoacts-project:mainfrom
niermann999:ref-prevent-track-conversion

Conversation

@niermann999
Copy link
Copy Markdown
Collaborator

@niermann999 niermann999 commented Jan 24, 2026

Merge the parameter transporter and parameter resetter to a single composite actor, with any actor that relies on the bound track parameters as their observers. This way, actors like the material interactor cannot be added to the actor chain without the parameter updater present and the parameter resetter cannot be omitted by accident either without a compiler error.

The observing actors are now only triggered if the new actor result type sets a notify flag, making checking for the navigation to be on surface necessary only in the parameter updater.

@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch from 5533ba8 to cb1b7f2 Compare January 26, 2026 10:26
@niermann999 niermann999 added priority: low Low priority performance Improvements to compute performance labels Jan 26, 2026
@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch 5 times, most recently from 0765db4 to cb4ee1b Compare February 2, 2026 14:35
@niermann999 niermann999 marked this pull request as ready for review February 2, 2026 14:35
@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch 3 times, most recently from 98a3c56 to 9eb38cb Compare February 2, 2026 18:28
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 2, 2026

@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch from 9eb38cb to a751e9a Compare March 24, 2026 14:23
@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch 2 times, most recently from a4eb739 to 2ffc40c Compare March 24, 2026 16:17
@stephenswat

This comment was marked as outdated.

@niermann999 niermann999 changed the title Ref: prevent track conversion Ref: Merge parameter transporter and resetter to parameter updater Mar 24, 2026
@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch from 2ffc40c to 1454a0c Compare March 24, 2026 17:34
@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch 4 times, most recently from 1c90b47 to 6a29182 Compare March 25, 2026 15:49
@niermann999
Copy link
Copy Markdown
Collaborator Author

Tested in acts-project/traccc#1244

@stephenswat
Copy link
Copy Markdown
Member

Performance summary

Here is a summary of the performance effects of this PR:

Tabular

Benchmarkf86a37b6a29182Delta
ThroughputCVThroughputCV
ODD (1 GeV, cov. on)2.46 MHz0.05%2.55 MHz0.07%+3.71%
ODD (1 GeV, cov. off)4.73 MHz0.04%4.94 MHz0.06%+4.33%
ODD (10 GeV, cov. on)3.18 MHz0.05%3.29 MHz0.07%+3.42%
ODD (10 GeV, cov. off)5.83 MHz0.08%6.12 MHz0.06%+4.95%
ODD (100 GeV, cov. on)3.37 MHz0.06%3.48 MHz0.05%+3.27%
ODD (100 GeV, cov. off)6.09 MHz0.07%6.39 MHz0.03%+4.90%
ODD ([1, 100) GeV, cov. on)2.87 MHz0.08%3.00 MHz0.10%+4.81%
ODD ([1, 100) GeV, cov. off)5.63 MHz0.14%5.83 MHz0.04%+3.56%
Toy detector ([1, 100) GeV, cov. on)14.86 MHz0.57%14.97 MHz0.33%+0.75%
Toy detector ([1, 100) GeV, cov. off)23.80 MHz0.55%24.28 MHz0.78%+2.04%
Wire chamber ([1, 100) GeV, cov. on)11.40 MHz0.02%11.45 MHz0.06%+0.38%
Wire chamber ([1, 100) GeV, cov. off)20.40 MHz0.03%20.84 MHz0.03%+2.20%

Note

This is an automated message produced upon the explicit request of a human being.

@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch from 6a29182 to aae1765 Compare March 25, 2026 18:09
@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch from aae1765 to 46bc383 Compare March 25, 2026 19:16
@niermann999 niermann999 changed the title Ref: Merge parameter transporter and resetter to parameter updater ref: Merge parameter transporter and resetter to parameter updater Mar 26, 2026
@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch from 46bc383 to f9df282 Compare March 27, 2026 10:18
Copy link
Copy Markdown
Member

@stephenswat stephenswat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to accept a small slowdown here if it simplifies the code.

@niermann999
Copy link
Copy Markdown
Collaborator Author

Happy to accept a small slowdown here if it simplifies the code.

I thought this is a throughput increase, or am I reading the results wrong?

@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch 7 times, most recently from 68424b1 to b2b8a40 Compare March 30, 2026 14:35
@stephenswat
Copy link
Copy Markdown
Member

I thought this is a throughput increase, or am I reading the results wrong?

You are correct I am dumb.

@niermann999 niermann999 force-pushed the ref-prevent-track-conversion branch from b2b8a40 to e25b845 Compare March 31, 2026 16:10
@sonarqubecloud
Copy link
Copy Markdown

@niermann999 niermann999 merged commit 3532b4d into acts-project:main Apr 1, 2026
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Improvements to compute performance priority: low Low priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants