Open
Conversation
m-brettell
force-pushed
the
GBTS_new_seed_extraction
branch
from
fb414a4 to
5da4446
Compare
|
1 similar comment
|
m-brettell
force-pushed
the
GBTS_new_seed_extraction
branch
from
e5ec6d1 to
44cc383
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhall of the seed extraction kernels:
Now extract all paths through the graph into path_store <- size can be counted in the CCA, so no more exceedable maximums for those allocations. This reduces both the allocation size and now only an int2 is passed in and out of memory while branching through the graph, rather than the large edgeState (80 bytes).
All paths are then fit to obtain a quality score for disambiguation rather than fitting only some at a time.
One bidding round selects only the highest quality seed starting at each edge. Then the same iterative bidding occurs to pick the best seeds as before. The change to the first round improves seed purity and high pT efficiency.
Reduces the seed extraction kernel latency by ~3x and improves high pT efficiency