Acts <--> Traccc Track Container, main branch (2025.11.14.)#1197
Draft
krasznaa wants to merge 3 commits intoacts-project:mainfrom
Draft
Acts <--> Traccc Track Container, main branch (2025.11.14.)#1197krasznaa wants to merge 3 commits intoacts-project:mainfrom
krasznaa wants to merge 3 commits intoacts-project:mainfrom
Conversation
krasznaa
force-pushed
the
ActsTrackContainer-main-20251114
branch
from
23593cf to
d93794b
Compare
| } | ||
|
|
||
| // Construct the covariance expected by Acts. | ||
| return ConstTrackStateProxy::ConstCovariance{covariance.data()}; |
Member
There was a problem hiding this comment.
So, this will be dangling immediately, right? This is a bit the weakness of the current design that I chose, where the interface expects to be able to hand out references that the caller can manipulate directly. This probably prevents doing on the fly conversion here.
Member
Author
There was a problem hiding this comment.
I didn't look at this in detail. Just assumed that the object probably makes a copy.
It is a defendable design that it doesn't. But then indeed this code will need to be written differently. 🤔
There is no world in which the code would actually work at this point. But at least it compiles. So it could be a good starting point for discussions hopefully.
Just to make sure that the code compiles, and does the most trivial thing imaginable.
krasznaa
force-pushed
the
ActsTrackContainer-main-20251114
branch
from
d93794b to
fa95337
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent the better half of today experimenting with the following. As I told people multiple times in the past, I very much want to figure out how we can put an Acts::TrackContainer on top of the traccc data collections/containers. So that after we copy the reconstructed tracks back to the host, we would not need to translate them anymore. We could just put such an adapter layer on top of them, and voila.
That's the idea anyway. For now I just fumbled around with the code based on what I could find in code written by @paradajzblond and @CarloVarni. So, this PR is just a super rough first version of how I managed to understand the code so far. But I'll definitely want to discuss next week with @CarloVarni and @paulgessinger about the details. 🤔
Even until then, feel very free to criticise this code already. I cannot imagine that I would not have done some silly stuff in it. 🤔