Skip to content

Make deterministic event order the default #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenswat merged 2 commits into from
Apr 9, 2026
Merged

Make deterministic event order the default #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80e34dc
Make deterministic the default
StewMH Feb 19, 2026
c2898d8
Add deterministic commit to profiling tool
StewMH Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/options/include/traccc/options/throughput.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class throughput : public interface {
std::size_t cold_run_events = 10;

/// Enable or disable the randomization of event processing
bool deterministic_event_order = false;
bool deterministic_event_order = true;
Comment thread
krasznaa marked this conversation as resolved.
/// Set the random event processing seed
unsigned int random_seed = 0;

Expand Down
2 changes: 1 addition & 1 deletion examples/options/src/throughput.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ throughput::throughput() : interface("Throughput Measurement Options") {
po::value(&cold_run_events)->default_value(cold_run_events),
"Number of events to run 'cold'");
m_desc.add_options()("deterministic",
po::bool_switch(&deterministic_event_order)
po::value<bool>(&deterministic_event_order)
->default_value(deterministic_event_order),
"Process events in deterministic order");
m_desc.add_options()("random-seed",
Expand Down
8 changes: 7 additions & 1 deletion extras/benchmark/traccc_bench_tools/profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@


DETERMINISTIC_ORDER_COMMIT = "7e7f17ccd2e2b0db8971655773b351a365ee1cfc"
DETERMINISTIC_DEFAULT_COMMIT = "80e34dc2195fc3897f1d7d97a71c0701edaa6aa1"
BOOLEAN_FLAG_COMMIT = "380fc78ba63a79ed5c8f19d01d57636aa31cf4fd"
INHOMOGENEOUS_BFIELD_COMMIT = "3654a64d5fe06509e6bf8be332f5aae7b8ff2da9"

Expand Down Expand Up @@ -44,7 +45,12 @@ def run_profile(
if ncu_wrapper is not None:
profile_args = ncu_wrapper.split() + profile_args

if git.is_parent_of(commit, DETERMINISTIC_ORDER_COMMIT):
if git.is_parent_of(commit, DETERMINISTIC_DEFAULT_COMMIT):
log.info(
"Commit is a child of (or is) %s; deterministic processing is default",
DETERMINISTIC_DEFAULT_COMMIT[:8],
)
elif git.is_parent_of(commit, DETERMINISTIC_ORDER_COMMIT):
log.info(
"Commit is a child of (or is) %s; enabling deterministic processing",
DETERMINISTIC_ORDER_COMMIT[:8],
Expand Down
Loading