GBTS node creation handling of unconfigured volumes#1284
Open
mimodekjaer wants to merge 1 commit intoacts-project:mainfrom
Open
GBTS node creation handling of unconfigured volumes#1284mimodekjaer wants to merge 1 commit intoacts-project:mainfrom
mimodekjaer wants to merge 1 commit intoacts-project:mainfrom
Conversation
This is a bugfix for the GBTS node creation so the spacepoints from unconfigured volumes are fully skipped.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix for the GBTS node creation so the spacepoints from unconfigured volumes are fully skipped.
This fixes an illegal memory access happening because the spacepoint where skipped in the count_sp_by_layer kernel, while still being processed in the bin_sp_by_layer kernel. This uses the pre-existing check to remove the spacepoint from further processing.