Conversation
masterleinad
force-pushed
the
compiler_warnings
branch
from
3f1f5f6 to
0c4a42e
Compare
Yes, don't merge it. I will do a proper review later but we should not merge as is. |
ci/Dockerfile
Outdated
| -DTrilinos_ENABLE_SEACAS=ON \ | ||
| -DTrilinos_ENABLE_EXPLICIT_INSTANTIATION=ON \ | ||
| -DKokkos_ENABLE_CUDA=$CUDA \ | ||
| -DKokkos_ENABLE_CUDA_CONSTEXPR=$CUDA \ |
There was a problem hiding this comment.
Don't modify the Dockerfile. This will unsync the image with the Dockerfile.
There was a problem hiding this comment.
OK. I'll remove but most of the warnings are related to setting this option.
There was a problem hiding this comment.
Then why are you setting this option if it creates a bunch of warnings?
There was a problem hiding this comment.
It removes all warnings related to calling constexpr host functions. This is also what we are doing in the deal.II CI, see https://github.com/dealii/dealii/blob/3c3910b004cec9be552eb224ceba4bc6fecd47b6/.github/workflows/linux.yml#L335, and we check for this option to be set for an external standalone Kokkos, see https://github.com/dealii/dealii/blob/3c3910b004cec9be552eb224ceba4bc6fecd47b6/cmake/modules/FindDEAL_II_KOKKOS.cmake#L53.
masterleinad
force-pushed
the
compiler_warnings
branch
from
0c4a42e to
166710a
Compare
3 participants
While working on #282, I noticed that there are more warnings which this pull request fixes. I wasn't sure if we wanted to enforce this with
-Werroror similar.