Improve search for cells intersecing with heat sources

[masterleinad]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @masterleinad, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the algorithm for identifying cells that intersect with heat sources. By transitioning from a custom ArborX wrapper and std::unordered_set to a more direct integration with ArborX's native BVH and Kokkos views, the changes aim to improve the efficiency and performance of these intersection queries, particularly for large-scale simulations.

Highlights

• Refactored Intersection Search: The cell-heat source intersection search logic has been refactored to utilize ArborX's native BVH implementation directly, leveraging Kokkos views for improved performance and memory management.
• New Utility Classes and Functions: Introduced an IntersectionCallback class for efficient processing of ArborX query results and a to_arborx_box utility function for converting dealii::BoundingBox objects to ArborX's ExperimentalHyperGeometry::Box format.
• Optimized Cell Refinement Condition: The condition for identifying cells to refine now directly uses the results from the Kokkos-based intersection query, streamlining the process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• application/adamantine.hh
  • Added IntersectionCallback class to handle ArborX query results.
  • Added to_arborx_box utility function for bounding box conversion.
  • Replaced the previous bounding volume hierarchy (BVH) construction and query logic with a new ArborX BVH implementation using Kokkos views.
  • Updated the cell refinement condition to use the results from the new Kokkos-based intersection query.

Activity

• No human activity has been recorded on this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the search for cells intersecting with heat sources to improve performance. The change involves switching from deal.II's ArborX wrappers to using ArborX directly. A key optimization is swapping the roles of primitives and queries in the spatial search: the BVH tree is now built on heat source bounding boxes, and queries are performed for cell bounding boxes. This is a sensible approach, especially when there are many more cells than heat sources. The new implementation is cleaner and leverages Kokkos and ArborX more effectively. I have one minor suggestion to further improve the code.

[gemini-code-assist]

To avoid an unnecessary copy of the dealii::BoundingBox object, it's better to pass it by const reference. While dealii::BoundingBox is a relatively small object, passing by const& is a good C++ practice for non-trivial types and can offer a minor performance improvement.

ArborX::ExperimentalHyperGeometry::Box<dim, double>
to_arborx_box(const dealii::BoundingBox<dim> &dealii_box)