#381 Vanilla Theme Picker Optimisation#404
Open
zubairslamdien wants to merge 13 commits intoadaptlearning:masterfrom
Open
#381 Vanilla Theme Picker Optimisation#404zubairslamdien wants to merge 13 commits intoadaptlearning:masterfrom
zubairslamdien wants to merge 13 commits intoadaptlearning:masterfrom
Conversation
schema change for font uploads
Heading text changed, sections rearranged and weight properties now use dropdowns and italics instruction text checkbox added.
File upload order changed. More family and weight properties added. External Font array added
-Font file order changed -Default values added for all font fields -Subtitle section removed -Link font family removed -Custom CSS/Less editor textbox added
1 task
taylortom
requested changes
Mar 23, 2023
Member
taylortom
left a comment
taylortom
left a comment
There was a problem hiding this comment.
As there's no planned support for these extra theme settings in the legacy AAT, we should forget adding the settings to the old properties schema
Author
|
I've removed the schema changes from the legacy file. |
taylortom
approved these changes
Apr 19, 2023
StuartNicholls
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #381
Update