Skip to content

New: Add page header graphic (fix #557)#580

Merged
swashbuck merged 5 commits intomasterfrom
issue/557
Apr 6, 2026
Merged

New: Add page header graphic (fix #557)#580
swashbuck merged 5 commits intomasterfrom
issue/557

Conversation

@swashbuck
Copy link
Copy Markdown
Contributor

@swashbuck swashbuck commented Feb 25, 2026

Fix #557

New

  • Adds new page header graphic option for including a logo above the page title.

Notes

  • Page header graphic max width must be set via custom styling
  • This could alternatively be implemented in Core rather than Vanilla. This would be implemented directly in the page template rather than needing to use jQuery to inject the element. However, we would have some page header settings in Vanilla and some in Core which may be confusing.

Screenshots

Page header

@swashbuck swashbuck moved this from New to Assigned in adapt_framework: The TODO Board Feb 25, 2026
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Feb 25, 2026
@swashbuck swashbuck marked this pull request as ready for review February 25, 2026 18:03
Copy link
Copy Markdown
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @swashbuck, I agree it makes sense to keep page header settings in Vanilla rather than split. Whilst consistency in implementation is preferred (page template rather than jQuery) it's important to consider end user experience. Having split settings within AAT would be confusing.

I've raised a few comments but otherwise works as expected thanks 👍

Comment thread js/themePageView.js Outdated
Comment thread less/core/page.less
Comment thread less/core/page.less Outdated
@swashbuck
Copy link
Copy Markdown
Contributor Author

Thanks, @kirsty-hames . I've addressed your three comments and implemented the changes.

@swashbuck swashbuck merged commit 7f32e64 into master Apr 6, 2026
@swashbuck swashbuck deleted the issue/557 branch April 6, 2026 16:28
@github-project-automation github-project-automation Bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 6, 2026

🎉 This PR is included in version 9.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page header graphic

3 participants