Fix: Empty build.excludes or build.includes array breaks the build (fixes #3786)#3787
Open
Fix: Empty build.excludes or build.includes array breaks the build (fixes #3786)#3787
Conversation
swashbuck
moved this from Assigned
to Needs Reviewing
in adapt_framework: The TODO Board
oliverfoster
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3786
Fix
.lengthchecks to theincludes,excludes, andproductionExcludesguards ingenerateConfigData()so empty arrays are treated the same as undefinedEmpty arrays are truthy in JavaScript, so
if (buildConfig.excludes)passes for[]. This propagates intogenerateExcludedRegExp()where[].map(...).join('|')produces an empty string, andnew RegExp('', 'i')matches every file path - silently excluding all plugins.Testing
"build": { "excludes": [] }inconfig.jsongrunt build- verify the build completes normally (noapplyDefaultserror)"build": { "includes": [] }inconfig.jsongrunt build- verify the build completes normallybuildkey entirely - verify the build still works (regression check)