fix: share task store across stateless HTTP requests in serve()#443
Merged
fix: share task store across stateless HTTP requests in serve()#443
Conversation
serve() created a new InMemoryTaskStore per request, so tasks/get on subsequent requests returned "Task not found". Now serve() creates one shared store and passes it to the factory via ServeContext. Closes #442 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serve()created a newInMemoryTaskStoreper HTTP request, sotasks/geton subsequent requests returned "Task not found" — breaking all async tool calls over stateless Streamable HTTPserve()creates one shared task store and passes it to the factory via a newServeContextparameterBUILD-AN-AGENT.md,llms.txt), and exportsCloses #442
Test plan
test/lib/serve-tasks.test.js:taskStoreviaServeOptionstaskStorereference across all requestsserve.test.jstests passmcp-tasks-compat.test.jstests pass🤖 Generated with Claude Code