Feat: Add support for horizontal orientation to GridList & ListBox#8533
Feat: Add support for horizontal orientation to GridList & ListBox#8533nwidynski wants to merge 12 commits intoadobe:mainfrom
orientation to GridList & ListBox#8533Conversation
…to layout-orientation
…ayout-orientation
|
@LFDanLu Would you be so kind to issue a build for this PR? I'm going insane because of a bug with virtualized dnd, which I can't seem to get rid of locally, even after reverting all changes and clearing caches. I would really like to know whether the issue exists on remote 😅 |
orientation to ListLayout delegateorientation to GridList & ListBox
| 'aria-multiselectable': 'true' | ||
| } : {}, { | ||
| role: 'listbox', | ||
| 'aria-orientation': orientation === 'horizontal' ? orientation : undefined, |
There was a problem hiding this comment.
@majornista Should we set aria-orientation only if deviating from the implicit orientation as defined in each role spec? I adjusted useTabList as well to match, let me know what you think 🙏
|
@nwidynski heya sorry about the delay, opened #8544 for your build |
|
@LFDanLu Thanks! I will take a look tmrw, otherwise this is ready for review if the team finds time 👍 |
|
sounds good, we are gearing up for a release very soon, but noted this one down (and #8523) for the team to checkout right after! |
LFDanLu
left a comment
There was a problem hiding this comment.
Will be bring this up with the team tomorrow, but looks good to me at a glance, thanks!
|
mainly wondering if some of the changes/refactors can be simplified since we already supported orientation for Listbox previously |
|
@LFDanLu Maybe the PR title is misleading - The primary target of this is to add |
b6452fc to
2d97559
Compare
|
@LFDanLu I removed the fallback as requested, anything else blocking this? One question I had was whether we should tackle #837 (comment) as a result of |
|
Nothing blocking from my perspective, but the team is in a holding pattern for your coming RFC so we can see how it all fits together. Definitely sounds like the getOrientation stuff could help with that comment you linked, happy for that to be follow up |
|
Thank you for working on this PR! Am I correct in assuming this would help allow horizontal drag and drop using GridList? Currently, I have an issue where the Left Right placement of the DragIndicator changes based on the Y position you are dragging and not the X position. I would also really appreciate an Thank you! Screen.Recording.2025-08-30.at.2.00.03.PM.mov |
|
@nwidynski Awesome and no worries, thank you so much for making that! Just to share some timelines, the team is currently pushing quite heavily on work around our new docs site, so the next month or two will be a bit hectic on our end. We'll definitely try to carve out some time so we can start discussions early though! |
|
@LFDanLu Is there anything I can do to get this over the finish line? Now that the RFC is out, I think the reasoning for this PR should be apparent. |
|
Heya, I just got back from vacation sorry about the delay, I'll bump the team on your RFC again and see if I can get another pair of eyes on it and then we can see about getting these related PRs in. |
|
@LFDanLu Since Devon is heading into 2 weeks off now, do you mind taking a look at my latest reply to his questions and see whether that lines up with your idea of what this RFC tries to do? Just want to ensure Devon can wrap it up once he's back, so we can skip this back and forth dragging on for further weeks. PS: Sorry for the rather long read once more 😅 |
This PR adds support for
horizontalorientations toListLayoutand affected components in preparation for aCarouselcontribution.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: