Fix .NET8 for AOT / Single Executable#142
Open
DashNY wants to merge 1 commit intoadoconnection:masterfrom
Open
Fix .NET8 for AOT / Single Executable#142DashNY wants to merge 1 commit intoadoconnection:masterfrom
DashNY wants to merge 1 commit intoadoconnection:masterfrom
Conversation
Author
|
hey @adoconnection just checking if you had a chance to review. Without this change, we're force to manually pin those newer versions in our |
Owner
|
Hi, sorry, was a bit busy. Thanks for PR looks good to me! Very handy update |
Hi, this might be useful for us as well. Could this be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the references to
Microsoft.AspNetCore.Razor.LanguageandMicrosoft.CodeAnalysis.CSharpto their latest versions in order to fix the Ahead-of-Time (AOT) compilation of the assembly in .NET 8.AOT allows publishing of your entire application as a single executable, with all assemblies pre-compiled natively, resulting in faster startup time.
The older versions of those libraries are not compatible with AOT and cause errors when publishing for AOT.
The upgrade does not appear to cause any issues, and all tests still pass.
I've added ExampleAppNET8 project, and AOT functionality can be tested by right-clicking it and selecting Publish.