Added callbacks to ArchiveFile.Extract and Entry.Extract for progress events.#60
Open
runemoennike wants to merge 2 commits intoadoconnection:masterfrom
Open
Added callbacks to ArchiveFile.Extract and Entry.Extract for progress events.#60runemoennike wants to merge 2 commits intoadoconnection:masterfrom
runemoennike wants to merge 2 commits intoadoconnection:masterfrom
Conversation
added 2 commits
August 23, 2022 13:10
…ests failing for everything but 7zip format.
Open
Owner
|
Rune, thanks for your work! |
Author
|
No worries :) |
|
@runemoennike is it possible for you to give me the updates source and a test function that can monitor the progress please? thanks in advance @runemoennike @adoconnection best regards |
Author
|
@SalmaBegumJSR you have to clone my fork of the repo, and switch to branch 55. If you do it from a terminal/console, it looks like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IArchiveExtractCallback contains SetTotal and SetCompleted which are called at various points during file extraction. These points differ between file formats, but along with GetStream some form of progress reporting is possible, which is what this commit introduces.
The Extract methods on ArchiveFile and Entry now accept an event handler that will be called with the new ArchiveExtractionProgressEventArgs and EntryExtractionProgressEventArgs, respectively, as the extraction progresses. Please note that it is very inconsistent when this is invoked, depending on the format. However, it is guaranteed to be called at least at the beginning and end of extracting each file.