Open
Conversation
added 2 commits
March 13, 2019 20:19
… of php-ast - Using version `70` in php-ast instead of version `30` - Some typos
Owner
|
Hi, thank you for this PR. Does it work for you? When I tried the AST version 70, the resulting json didn't have correct values in "name" attribute - it was always This was a one-time project and as I implemented it a long time ago, it will be difficult to try to fix but I will give it a go when have more time... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backend/php-ast/util.phpto work with most recent version of php-ast70in php-ast instead of version30$argv[1]) instead of having to type it in every time you run the script